fix: fixed column filters in job list and job history tables - #430
Merged
Conversation
mdiapenabc
requested changes
Aug 5, 2026
mdiapenabc
left a comment
Collaborator
There was a problem hiding this comment.
Job Name filter uniformity looks good.
For Trigger By: good fix replacing USER with actual IDIR values, but triggerOptions is derived only from loaded rows (Job List latest-per-type ~6 rows + Job History current page). Since Job History filters over 1 month server-side, users may not be able to filter by valid IDIRs unless that IDIR happens to be on the current page. Please source distinct Trigger By values from the full 1-month monitoring scope
Minor: remove unused USER branch in matchesTriggerFilter.
mdiapenabc
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job Monitoring Filter Consistency and Trigger By Fix
This PR addresses filter inconsistencies in Job Monitoring, starting with the Trigger By column issue and then aligning Job Name filter behavior between Job List and Job History.
Problem 1: Trigger By filter values were incorrect
SYSTEMCGWRK22)SYSTEMand a genericUSER, which was not aligned with requirements.Fix 1: Trigger By filter options updated
SYSTEMfirstProblem 2: Job Name filter behavior was inconsistent
Fix 2: Job Name filter behavior made uniform
Fixes # (issue)
Type of change
How Has This Been Tested?
Checklist
In Progress/Follow Up