Skip to content

fix: fixed column filters in job list and job history tables - #430

Merged
plakkara-bc merged 6 commits into
devfrom
fix/monitoring-ui-filters
Aug 5, 2026
Merged

fix: fixed column filters in job list and job history tables#430
plakkara-bc merged 6 commits into
devfrom
fix/monitoring-ui-filters

Conversation

@plakkara-bc

@plakkara-bc plakkara-bc commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Job Monitoring Filter Consistency and Trigger By Fix

This PR addresses filter inconsistencies in Job Monitoring, starting with the Trigger By column issue and then aligning Job Name filter behavior between Job List and Job History.

Problem 1: Trigger By filter values were incorrect

  • AC expected Trigger By filter values to represent:
    • SYSTEM
    • specific end-user IDIRs (for example CGWRK22)
  • Actual behavior showed SYSTEM and a generic USER, which was not aligned with requirements.

Fix 1: Trigger By filter options updated

  • Replaced static Trigger By options with dynamic values derived from monitoring data.
  • Trigger By LOV now shows:
    • SYSTEM first
    • followed by discovered IDIR values (sorted)
  • Applied consistently to both:
    • Job List Trigger By filter
    • Job History Trigger By filter
  • Updated matching logic to handle case-insensitive comparisons safely.

Problem 2: Job Name filter behavior was inconsistent

  • Job History Job Name used LOV dropdown.
  • Job List Job Name used free-text filter.
  • Same field had different UX patterns.

Fix 2: Job Name filter behavior made uniform

  • Changed Job List Job Name filter from text input to LOV dropdown.
  • Reused the same monitored Job Name option set as Job History.
  • Updated Job List Job Name filtering to exact LOV selection behavior (not substring text search).

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Automated/Unit tests
  • Manual tests (description below)
  • No new tests are required

Checklist

  • I have tested my changed locally
  • The code builds and pass all tests, No warning
  • I have made corresponding changes to the documentation

In Progress/Follow Up

@mdiapenabc mdiapenabc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job Name filter uniformity looks good.

For Trigger By: good fix replacing USER with actual IDIR values, but triggerOptions is derived only from loaded rows (Job List latest-per-type ~6 rows + Job History current page). Since Job History filters over 1 month server-side, users may not be able to filter by valid IDIRs unless that IDIR happens to be on the current page. Please source distinct Trigger By values from the full 1-month monitoring scope

Minor: remove unused USER branch in matchesTriggerFilter.

@plakkara-bc
plakkara-bc merged commit 7ddb2c0 into dev Aug 5, 2026
15 checks passed
@plakkara-bc
plakkara-bc deleted the fix/monitoring-ui-filters branch August 5, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants