Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions backend/src/api/jobs/jobs.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,21 @@ import { JobActivityType } from 'src/jobs/enums/job-activity-type.enum'
import { JobStatus } from 'src/jobs/enums/job-status.enum'
import { JobTrigger } from 'src/jobs/enums/job-trigger.enum'
import { JobType } from 'src/jobs/enums/job-type.enum'
import {
formatJobDisplayName,
formatJobSummary,
formatMonitoringStatus,
formatTriggeredBy,
} from 'src/jobs/job-monitoring.utils'
import { JobRunner } from 'src/jobs/job-runner.service'
import {
JobsService,
type MonitoringActivityFilters,
type MonitoringHistoryFilters,
} from 'src/jobs/jobs.service'
import { OpenshiftJobLauncher } from 'src/jobs/openshift-job-launcher.service'
import {
formatJobDisplayName,
formatJobSummary,
formatMonitoringStatus,
formatTriggeredBy,
} from 'src/jobs/job-monitoring.utils'
import { CSAGuard } from '../common/guards/csa.guard'
import { CurrentUser } from '../common/decorators/current-user.decorator'
import { CSAGuard } from '../common/guards/csa.guard'
import { canRunBulkJobInApiProcess } from './bulk-job-deploy-env'
import { getJobRunWarning } from './job-openshift-advisory'

Expand Down Expand Up @@ -316,6 +316,12 @@ export class JobsController {
}
}

@Get('monitoring/triggered-by')
@ApiResponse({ status: 200, description: 'Distinct Trigger By values for monitored jobs' })
async getMonitoringTriggeredBy() {
return this.jobsService.getMonitoringTriggeredByValues()
}

@Get('monitoring/activities')
@ApiResponse({ status: 200, description: 'Recent monitoring activities' })
async getRecentActivities(
Expand Down
14 changes: 14 additions & 0 deletions backend/src/api/jobs/jobs.controllers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ describe('JobsController', () => {
getJobs: vi.fn(),
getLatestJobsPerType: vi.fn(),
getJobHistory: vi.fn(),
getMonitoringTriggeredByValues: vi.fn(),
getRecentActivities: vi.fn(),
getActivities: vi.fn(),
markFailed: vi.fn(),
Expand Down Expand Up @@ -470,6 +471,19 @@ describe('JobsController', () => {
})
})

describe('GET /jobs/monitoring/triggered-by', () => {
it('should return distinct trigger values for monitoring filters', async () => {
mockJobsService.getMonitoringTriggeredByValues.mockResolvedValue(['SYSTEM', 'CGWRK22'])

const res = await request(app.getHttpServer())
.get('/jobs/monitoring/triggered-by')
.expect(200)

expect(mockJobsService.getMonitoringTriggeredByValues).toHaveBeenCalled()
expect(res.body).toEqual(['SYSTEM', 'CGWRK22'])
})
})

describe('GET /jobs/monitoring/activities', () => {
it('should return recent activities with pagination and filters', async () => {
mockJobsService.getRecentActivities.mockResolvedValue({
Expand Down
37 changes: 25 additions & 12 deletions backend/src/jobs/jobs.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,18 +302,6 @@ describe('JobsService', () => {
)
})

it('should filter monitoring history by USER using jobTrigger', async () => {
await service.getJobHistory({ triggeredBy: 'USER' })

expect(prisma.jobRun.findMany).toHaveBeenCalledWith(
expect.objectContaining({
where: expect.objectContaining({
jobTrigger: JobTrigger.END_USER,
}),
}),
)
})

it('should query history for monitored types including ICM/MIS child runs', async () => {
await service.getJobHistory()

Expand Down Expand Up @@ -344,6 +332,31 @@ describe('JobsService', () => {
)
})

it('should return distinct trigger values for full monitoring scope', async () => {
vi.spyOn(prisma.jobRun, 'findMany').mockResolvedValue([
{ jobTrigger: JobTrigger.CRON, triggeredByUser: null },
{ jobTrigger: JobTrigger.END_USER, triggeredByUser: 'jsmith' },
{ jobTrigger: JobTrigger.END_USER, triggeredByUser: 'adoe' },
{ jobTrigger: JobTrigger.END_USER, triggeredByUser: 'JSMITH' },
] as any)

const result = await service.getMonitoringTriggeredByValues()

expect(prisma.jobRun.findMany).toHaveBeenCalledWith(
expect.objectContaining({
where: expect.objectContaining({
startedAt: { gte: expect.any(Date) },
}),
select: {
jobTrigger: true,
triggeredByUser: true,
},
distinct: ['jobTrigger', 'triggeredByUser'],
}),
)
expect(result).toEqual(['SYSTEM', 'ADOE', 'JSMITH'])
})

it('should apply recent activity time window', async () => {
await service.getRecentActivities(1, 10)

Expand Down
90 changes: 62 additions & 28 deletions backend/src/jobs/jobs.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { JobStatus } from './enums/job-status.enum'
import { JobTrigger } from './enums/job-trigger.enum'
import { JobType } from './enums/job-type.enum'
import {
formatTriggeredBy,
isMonitoredChildJobType,
MONITORED_CHILD_JOB_TYPES,
MONITORED_JOB_HISTORY_TYPES,
Expand Down Expand Up @@ -49,6 +50,41 @@ export interface CreateJobDto {
export class JobsService {
constructor(private readonly prisma: PrismaService) {}

private getMonitoringHistoryScopeWhere(
filters: Pick<MonitoringHistoryFilters, 'jobType' | 'status' | 'jobId' | 'triggeredBy'> = {},
): Prisma.JobRunWhereInput {
const oneMonthAgo = new Date()
oneMonthAgo.setMonth(oneMonthAgo.getMonth() - 1)

const monitoredTypes = filters.jobType ? [filters.jobType] : MONITORED_JOB_HISTORY_TYPES

const where: Prisma.JobRunWhereInput = {
startedAt: { gte: oneMonthAgo },
jobType: { in: monitoredTypes },
OR: [{ jobType: { in: MONITORED_CHILD_JOB_TYPES } }, { parentJobId: null }],
...(filters.status && { status: filters.status }),
...(filters.jobId && { id: filters.jobId }),
}

if (filters.triggeredBy) {
if (filters.triggeredBy === 'SYSTEM') {
where.jobTrigger = { in: [JobTrigger.CRON, JobTrigger.SYSTEM] }
} else if (filters.triggeredBy === JobTrigger.END_USER) {
where.jobTrigger = JobTrigger.END_USER
} else if (
filters.triggeredBy === JobTrigger.CRON ||
filters.triggeredBy === JobTrigger.SYSTEM
) {
where.jobTrigger = filters.triggeredBy
} else {
where.jobTrigger = JobTrigger.END_USER
where.triggeredByUser = { equals: filters.triggeredBy, mode: 'insensitive' }
}
}

return where
}

async createJob(dto: CreateJobDto) {
const now = new Date()
const job = await this.prisma.jobRun.create({
Expand Down Expand Up @@ -304,34 +340,7 @@ export class JobsService {
async getJobHistory(filters: MonitoringHistoryFilters = {}) {
const page = filters.page ?? 1
const limit = filters.limit ?? 10
const oneMonthAgo = new Date()
oneMonthAgo.setMonth(oneMonthAgo.getMonth() - 1)

const monitoredTypes = filters.jobType ? [filters.jobType] : MONITORED_JOB_HISTORY_TYPES

const where: Prisma.JobRunWhereInput = {
startedAt: { gte: oneMonthAgo },
jobType: { in: monitoredTypes },
OR: [{ jobType: { in: MONITORED_CHILD_JOB_TYPES } }, { parentJobId: null }],
...(filters.status && { status: filters.status }),
...(filters.jobId && { id: filters.jobId }),
}

if (filters.triggeredBy) {
if (filters.triggeredBy === 'SYSTEM') {
where.jobTrigger = { in: [JobTrigger.CRON, JobTrigger.SYSTEM] }
} else if (filters.triggeredBy === 'USER' || filters.triggeredBy === JobTrigger.END_USER) {
where.jobTrigger = JobTrigger.END_USER
} else if (
filters.triggeredBy === JobTrigger.CRON ||
filters.triggeredBy === JobTrigger.SYSTEM
) {
where.jobTrigger = filters.triggeredBy
} else {
where.jobTrigger = JobTrigger.END_USER
where.triggeredByUser = { equals: filters.triggeredBy, mode: 'insensitive' }
}
}
const where = this.getMonitoringHistoryScopeWhere(filters)

const sortBy = filters.sortBy ?? 'startedAt'
const sortOrder = filters.sortOrder ?? 'desc'
Expand All @@ -349,6 +358,31 @@ export class JobsService {
return { data, total, page, limit }
}

async getMonitoringTriggeredByValues(): Promise<string[]> {
const rows = await this.prisma.jobRun.findMany({
where: this.getMonitoringHistoryScopeWhere(),
select: {
jobTrigger: true,
triggeredByUser: true,
},
distinct: ['jobTrigger', 'triggeredByUser'],
})

const values = Array.from(
new Set(
rows
.map((row) => formatTriggeredBy(row))
.map((value) => value.trim().toUpperCase())
.filter((value) => value.length > 0),
),
)

const sortedIdirs = values
.filter((value) => value !== 'SYSTEM')
.sort((a, b) => a.localeCompare(b))
return values.includes('SYSTEM') ? ['SYSTEM', ...sortedIdirs] : sortedIdirs
}

async addActivity(
jobRunId: number | null,
activity: { severity: JobActivitySeverity; type: JobActivityType; related?: string },
Expand Down
72 changes: 61 additions & 11 deletions frontend/src/components/JobMonitoringTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {
getJobActivities,
getJobHistory,
getLatestJobs,
getMonitoringTriggeredByValues,
getRecentActivities,
type ActivityParams,
type JobActivityRow,
Expand Down Expand Up @@ -61,7 +62,6 @@ const STATUS_TO_API: Record<string, string> = {
Running: 'RUNNING',
Failed: 'FAILED',
}
const TRIGGER_OPTIONS = ['SYSTEM', 'USER']
const ACTIVITY_SEVERITIES = ['ERROR', 'WARNING', 'CRITICAL']
const ACTIVITY_TYPES = ['DATA_QUALITY', 'JOB', 'CRA', 'WKL', 'ICM', 'BATCH']
const ACTIVITY_TYPE_LABELS: Record<string, string> = {
Expand Down Expand Up @@ -93,8 +93,7 @@ const normalizeStatus = (status: string): string => {

const matchesTriggerFilter = (triggeredBy: string, filter: string): boolean => {
if (!filter) return true
if (filter === 'USER') return triggeredBy !== 'SYSTEM'
return triggeredBy === filter
return triggeredBy.toUpperCase() === filter.toUpperCase()
}

const normalizeSeverity = (severity: string): string => {
Expand Down Expand Up @@ -357,6 +356,7 @@ export default function JobMonitoringTab() {
element: HTMLElement | null
column: ActivityFilterColumn | ''
}>({ element: null, column: '' })
const [triggerOptions, setTriggerOptions] = useState<string[]>([])

// ── Data fetching ───────────────────────────────────────────────────────
const fetchJobList = useCallback(async () => {
Expand Down Expand Up @@ -446,6 +446,15 @@ export default function JobMonitoringTab() {
actSortOrder,
])

const fetchTriggerOptions = useCallback(async () => {
try {
const values = await getMonitoringTriggeredByValues()
setTriggerOptions(values)
} catch {
setTriggerOptions([])
}
}, [])

useEffect(() => {
const timeoutId = window.setTimeout(() => {
void fetchJobList()
Expand All @@ -470,6 +479,14 @@ export default function JobMonitoringTab() {
return () => window.clearTimeout(timeoutId)
}, [fetchActivities])

useEffect(() => {
const timeoutId = window.setTimeout(() => {
void fetchTriggerOptions()
}, 0)

return () => window.clearTimeout(timeoutId)
}, [fetchTriggerOptions])

const hasRunningJobs = jobListData.some((row) => row.status.toUpperCase() === 'RUNNING')

useEffect(() => {
Expand Down Expand Up @@ -603,12 +620,31 @@ export default function JobMonitoringTab() {
actSortField !== 'when' ||
actSortOrder !== 'desc'

const fallbackTriggerOptions = (() => {
const found = new Set<string>()
const add = (value: string | null | undefined) => {
const normalized = (value || '').trim().toUpperCase()
if (!normalized) return
found.add(normalized)
}

jobListData.forEach((row) => add(row.triggeredBy))
jobHistoryData.forEach((row) => add(row.triggeredBy))

const sortedIdirs = Array.from(found)
.filter((v) => v !== 'SYSTEM')
.sort((a, b) => a.localeCompare(b))

return found.has('SYSTEM') ? ['SYSTEM', ...sortedIdirs] : sortedIdirs
})()
const availableTriggerOptions =
triggerOptions.length > 0 ? triggerOptions : fallbackTriggerOptions

// ── Job List: client-side filter + sort ──────────────────────────────────
const filteredJobList = jobListData
.filter((row) => {
if (jlFilterId && !String(row.id).includes(jlFilterId)) return false
if (jlFilterName && !row.jobName.toLowerCase().includes(jlFilterName.toLowerCase()))
return false
if (jlFilterName && row.jobName !== jlFilterName) return false
if (jlFilterStatus && row.status !== jlFilterStatus) return false
if (!matchesTriggerFilter(row.triggeredBy, jlFilterTrigger)) return false
return true
Expand Down Expand Up @@ -803,12 +839,26 @@ export default function JobMonitoringTab() {
/>
)}
{jlFilterAnchor.column === 'jobName' && (
<TextField
{...filterTextFieldProps}
<Select
size="small"
fullWidth
value={jlFilterName}
onChange={(e) => setJlFilterName(e.target.value)}
/>
displayEmpty
onChange={(e) => {
setJlFilterName(e.target.value)
closeJlFilter()
}}
sx={{ ...filterSelectSx, minWidth: 140 }}
>
<MenuItem value="">
<em>All</em>
</MenuItem>
{MONITORED_JOB_NAMES.map((n) => (
<MenuItem key={n} value={n} sx={{ fontSize: '0.75rem' }}>
{n}
</MenuItem>
))}
</Select>
)}
{jlFilterAnchor.column === 'status' && (
<Select
Expand Down Expand Up @@ -847,7 +897,7 @@ export default function JobMonitoringTab() {
<MenuItem value="">
<em>All</em>
</MenuItem>
{TRIGGER_OPTIONS.map((t) => (
{availableTriggerOptions.map((t) => (
<MenuItem key={t} value={t} sx={{ fontSize: '0.75rem' }}>
{t}
</MenuItem>
Expand Down Expand Up @@ -1121,7 +1171,7 @@ export default function JobMonitoringTab() {
<MenuItem value="">
<em>All</em>
</MenuItem>
{TRIGGER_OPTIONS.map((t) => (
{availableTriggerOptions.map((t) => (
<MenuItem key={t} value={t} sx={{ fontSize: '0.75rem' }}>
{t}
</MenuItem>
Expand Down
5 changes: 5 additions & 0 deletions frontend/src/service/jobs-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ export const getJobHistory = async (
return response.data
}

export const getMonitoringTriggeredByValues = async (): Promise<string[]> => {
const response = await APIService.getAxiosInstance().get('/jobs/monitoring/triggered-by')
return response.data
}

/**
* Get paginated recent monitoring activities (default Activities view)
*/
Expand Down
Loading