fix(diagnostics): classify core error markers case-insensitively#880
Conversation
7a01e4e to
768f54e
Compare
|
Automation validation (2026-07-02): focused fix for #541 is ready for review. Validated on head
Merge gate: wait for GitHub CI plus normal non-author review before squash merge. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a01e4e6a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert classify_error("installing dependencies") == "other" | ||
|
|
||
| def test_error_classification_is_case_insensitive_for_core_markers(self): | ||
| """Guards issue #541: core diagnostic markers should ignore case.""" |
There was a problem hiding this comment.
Name the guarded commit in the regression docstring
The repo-level AGENTS.md requires regression tests to name the PR or commit they guard, but this new regression docstring only cites issue #541. Please include the guarding PR or commit identifier here so the test follows the documented convention and remains traceable to the exact fix.
Useful? React with 👍 / 👎.
|
Users Simulation follow-up (2026-07-02T16:45Z): current head |
Summary
classify_error()use the already-normalized lowercase error string forinstall failedandACP errormarkersFixes #541.
Verification
uv sync --extra dev --lockeduv run python -m pytest tests/test_scoring.py -quv run ruff check src/benchflow/_utils/scoring.py tests/test_scoring.pyuv run ruff format --check src/benchflow/_utils/scoring.py tests/test_scoring.pyuv run ty check src/benchflow/_utils/scoring.py