Fix BGP open encoder and remove redundant param_length - #312
Merged
Conversation
ties
changed the title
ties
changed the title
ties
commented
Jul 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 90.15% 90.31% +0.16%
==========================================
Files 91 91
Lines 19159 19306 +147
==========================================
+ Hits 17272 17436 +164
+ Misses 1887 1870 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RFC 5492 (https://www.rfc-editor.org/rfc/rfc5492.html#section-4) defines capability length at one octet. This did not change with RFC 9072 extended OPEN. Each Add-Path entry is four octets and all Add-Path entries need to be in one capability, adding an effective upper limit of 63.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.