feat: add poll shape to Tldraw#15
Closed
danielpetri1 wants to merge 18 commits into
Closed
Conversation
Author
|
Closing in favor of #16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BigBlueButton displays a poll on the canvas, the client currently extends Tldraw with a custom shape. As a result, only the Tldraw instances tied to
bbb-html5profit from the functionality, despite other components, such asbbb-playback,bbb-export-annotations, andbbb-presentation-videoneeding to display such a poll.This PR is a stepstone towards centralizing the poll shape directly in Tldraw, which would close the following issues:
Development plan
Add the custom shape to the Tldraw fork
Change BBB 3.0 core to include the poll shape data in
tldraw.jsonforbbb-playback2.1. This automatically makes the new polls shapes appear in the recordings
Remove duplicated custom shape from BBB's client, using the new implementation instead (we are here)
Change Tldraw to include an image representation in the shape's
metaparameterUse the poll image in the annotation export
Use the poll image in the video
For the poll image, we can follow the same approach used by the slide snapshot: bigbluebutton/bigbluebutton#21005
Demo
tldraw.polls.mov