feat: add poll shape#16
Merged
Merged
Conversation
danielpetri1
force-pushed
the
poll-shape
branch
from
472276b to
30aceb3
Compare
danielpetri1
force-pushed
the
poll-shape
branch
from
50d74f0 to
67bc19e
Compare
Tainan404
pushed a commit
that referenced
this pull request
May 20, 2026
* fix type and build errors * update GitHub Actions runner to 4 cores for better availability * update GitHub Actions runner for better availability * fix linter and lint issues * fix tests / disable broken tests * add types * test update type * test update type * test update type * test update type * fix playwright e2e tests * remove unused config * update config * Add poll shape * Revert tsconfig * Use relative path for TLUiTranslationKey * Import defineMigration via relative pth * Run Prettier * Yarn lint * Fix yarn lint - disable extraneous dependencies * Add public-yarn lock * Fix webpack load issue * Allow whiteboardID parameter --------- Co-authored-by: KDSBrowne <kert.browne85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BigBlueButton displays a poll on the canvas, the client currently extends Tldraw with a custom shape. As a result, only the Tldraw instances tied to
bbb-html5profit from the functionality, despite other components, such asbbb-playback,bbb-export-annotations, andbbb-presentation-videoneeding to display such a poll.This PR is a stepstone towards centralizing the poll shape directly in Tldraw, which would close the following issues:
Development plan
Add the custom shape to the Tldraw fork
Change BBB 3.0 core to include the poll shape data in
tldraw.jsonforbbb-playback2.1. This automatically makes the new polls shapes appear in the recordings
Remove duplicated custom shape from BBB's client, using the new implementation instead (we are here)
Change Tldraw to include an image representation in the shape's
metaparameterUse the poll image in the annotation export
Use the poll image in the video
For the poll image, we can follow the same approach used by the slide snapshot: bigbluebutton/bigbluebutton#21005
Demo
tldraw.polls.mov