Skip to content

refactor: gallery component#1104

Merged
matthewvolk merged 1 commit intobigcommerce:refactor/ui-componentsfrom
drewpledger:dp/gallery-refactor
Jul 19, 2024
Merged

refactor: gallery component#1104
matthewvolk merged 1 commit intobigcommerce:refactor/ui-componentsfrom
drewpledger:dp/gallery-refactor

Conversation

@drewpledger
Copy link
Copy Markdown
Contributor

@drewpledger drewpledger commented Jul 19, 2024

CleanShot.2024-07-19.at.10.47.04.mp4

@drewpledger drewpledger requested a review from a team July 19, 2024 15:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ea7936

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 19, 2024

@drewpledger is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

@drewpledger drewpledger force-pushed the dp/gallery-refactor branch 2 times, most recently from 8b80af3 to c6881d3 Compare July 19, 2024 17:33
matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to export { Gallery }

@drewpledger drewpledger force-pushed the dp/gallery-refactor branch from c6881d3 to 086b146 Compare July 19, 2024 17:37
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 5:39pm

matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove className

matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove prop, if someone really wants to change no-image-text they can just edit the component

matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove cn

matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove className

matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove cn

matthewvolk
matthewvolk reviewed Jul 19, 2024
View reviewed changes
Comment thread core/components/ui/gallery/gallery.tsx Outdated
Copy link
Copy Markdown
Contributor

@matthewvolk matthewvolk Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be added to the first string?

@drewpledger drewpledger force-pushed the dp/gallery-refactor branch 4 times, most recently from c138717 to 9556844 Compare July 19, 2024 17:54
@drewpledger drewpledger force-pushed the dp/gallery-refactor branch from 9556844 to 2ea7936 Compare July 19, 2024 17:56
@matthewvolk matthewvolk merged commit 756ecfe into bigcommerce:refactor/ui-components Jul 19, 2024
deini pushed a commit that referenced this pull request Jul 19, 2024
@drewpledger @deini
refactor: gallery refactor (#1104)
08f14cb
jorgemoya pushed a commit that referenced this pull request Jul 30, 2024
@drewpledger @jorgemoya
refactor: gallery refactor (#1104)
2282865
bookernath pushed a commit that referenced this pull request Jul 30, 2024
@drewpledger @bookernath
refactor: gallery refactor (#1104)
8cebaf8
github-merge-queue Bot pushed a commit that referenced this pull request Jul 30, 2024
@jorgemoya @matthewvolk
@drewpledger @deini @avattipalli
refactor: ui components (#1178)
f592d9f 
* refactor: tag + usages (#1107)

* refactor(core): radio-group (#1106)

* fix: merge with main (#1105)

* refactor: remove file-chooser, no usages (#1110)

* refactor: carousel (#1109)

* refactor: badge (#1108)

* fix: eslint issues in tabs and badge

* refactor: gallery refactor (#1104)

* fix(core): lint issues from gallery refactor

* refactor(core): slideshow (#1111)

* refactor: message component (#1112)

* refactor: badge takes children (#1114)

* chore(core): delete skeleton (#1113)

* refactor: modal (#1115)

* refactor: button (#1116)

* fix: render cart count in badge

* refactor: datepicker uses popover primitives (#1118)

* refactor: accordions component (#1101)

* refactor(core): product card (#1117)

* refactor: input (#1131)

* refactor: textarea (#1134)

* refactor: checkbox (#1135)

* refactor: date picker (#1130)

* fix: radio group error state in pdp (#1133)

* refactor: pick list (#1139)

* fix: forward ref to button (#1140)

* refactor: select (#1143)

* fix: use correct font weight in badge (#1151)

* refactor: swatch (#1144)

* refactor: rectangle list (#1145)

* refactor: pick list props (#1146)

* refactor: radio group props (#1147)

* refactor: breadcrumbs (#1148)

* refactor: footer (#1154)

* fix: forward DatePicker ref (#1155)

* refactor: label (#1153)

* refactor: blog post card (#1152)

* refactor: rating (#1150)

* refactor: sheet (#1149)

* refactor: counter (#1136)

* refactor: header & navigation menu (#1160)

* fix: accordions props (#1162)

* fix: remove transparent overlay prop in Sheet (#1163)

* fix: gallery props (#1164)

* feat: add pageSize prop to carousels (#1165)

* chore: add changeset

* chore: update changeset

* fix: missing padding for sm viewport in quick search

* fix: close mobile nav on navigation

* fix: add aria-label to account tabs

* fix: skip blog post card regression

* fix: p wrapper for cart link

* fix: update header visual regression test

* fix: correct capitlization for tabs

* fix: change hover for on click in test

* fix: swatch test

* fix: changeset examples

* feat: add label prop to tabs

* fix: update account and register spec

* fix: update tests with latest changes

---------

Co-authored-by: Matthew Volk <matt.volk@bigcommerce.com>
Co-authored-by: Drew Pledger <drew@makeswift.com>
Co-authored-by: Daniel Almaguer <daniel.almaguer@bigcommerce.com>
Co-authored-by: Matthew Volk <volkmattj@gmail.com>
Co-authored-by: Anudeep Vattipalli <anudeep.vattipalli@bigcommerce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matthewvolk matthewvolk matthewvolk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drewpledger @matthewvolk