Skip to content

refactor: ui components#1178

Merged
jorgemoya merged 60 commits intomainfrom
refactor/ui-components
Jul 30, 2024
Merged

refactor: ui components#1178
jorgemoya merged 60 commits intomainfrom
refactor/ui-components

Conversation

@jorgemoya
Copy link
Copy Markdown
Contributor

What/Why?

Simplify UI components by removing composability and instead exposing a prop interface. Customizing components should now be easier than ever by having a single location for class manipulation.

Testing

Locally.

@jorgemoya jorgemoya requested a review from a team July 29, 2024 16:07
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 583a24d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 4:25pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jul 30, 2024 4:25pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:25pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:25pm
catalyst-test-store ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:25pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:25pm
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Jul 30, 2024 4:25pm

Comment thread .changeset/gold-carpets-attend.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could add an example of changing usage from the old style to the new in this changeset?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@github-actions
Copy link
Copy Markdown
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-26eyxu9hv-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 86
🟢 Accessibility 100
🟢 Best practices 96
🟠 SEO 85

@jorgemoya jorgemoya added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit f592d9f Jul 30, 2024
@jorgemoya jorgemoya deleted the refactor/ui-components branch July 30, 2024 17:10
@github-actions github-actions Bot mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants