refactor: counter#1136
Merged
jorgemoya merged 2 commits intorefactor/ui-componentsfrom Jul 25, 2024
Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
jorgemoya
commented
Jul 22, 2024
Comment on lines
+58
to
+59
| // eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/non-nullable-type-assertion-style | ||
| useImperativeHandle(ref, () => inputRef.current as ElementRef<'input'>); |
Contributor
Author
There was a problem hiding this comment.
Is there a better way to do this? I'm trying to use ref in sibling elements.
Contributor
There was a problem hiding this comment.
Using this is fine tbh, but you can type it better like so:
type CounterRef = ElementRef<'input'> | null;
const inputRef = useRef<CounterRef>(null);
useImperativeHandle<CounterRef, CounterRef>(ref, () => inputRef.current);
Contributor
Author
There was a problem hiding this comment.
This seems to work perfectly, thanks @chanceaclark
chanceaclark
approved these changes
Jul 24, 2024
Comment on lines
+58
to
+59
| // eslint-disable-next-line @typescript-eslint/consistent-type-assertions, @typescript-eslint/non-nullable-type-assertion-style | ||
| useImperativeHandle(ref, () => inputRef.current as ElementRef<'input'>); |
Contributor
There was a problem hiding this comment.
Using this is fine tbh, but you can type it better like so:
type CounterRef = ElementRef<'input'> | null;
const inputRef = useRef<CounterRef>(null);
useImperativeHandle<CounterRef, CounterRef>(ref, () => inputRef.current);
chanceaclark
approved these changes
Jul 24, 2024
Contributor
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-p1mjxt722-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
deini
approved these changes
Jul 25, 2024
jorgemoya
added a commit
that referenced
this pull request
Jul 30, 2024
bookernath
pushed a commit
that referenced
this pull request
Jul 30, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* refactor: tag + usages (#1107) * refactor(core): radio-group (#1106) * fix: merge with main (#1105) * refactor: remove file-chooser, no usages (#1110) * refactor: carousel (#1109) * refactor: badge (#1108) * fix: eslint issues in tabs and badge * refactor: gallery refactor (#1104) * fix(core): lint issues from gallery refactor * refactor(core): slideshow (#1111) * refactor: message component (#1112) * refactor: badge takes children (#1114) * chore(core): delete skeleton (#1113) * refactor: modal (#1115) * refactor: button (#1116) * fix: render cart count in badge * refactor: datepicker uses popover primitives (#1118) * refactor: accordions component (#1101) * refactor(core): product card (#1117) * refactor: input (#1131) * refactor: textarea (#1134) * refactor: checkbox (#1135) * refactor: date picker (#1130) * fix: radio group error state in pdp (#1133) * refactor: pick list (#1139) * fix: forward ref to button (#1140) * refactor: select (#1143) * fix: use correct font weight in badge (#1151) * refactor: swatch (#1144) * refactor: rectangle list (#1145) * refactor: pick list props (#1146) * refactor: radio group props (#1147) * refactor: breadcrumbs (#1148) * refactor: footer (#1154) * fix: forward DatePicker ref (#1155) * refactor: label (#1153) * refactor: blog post card (#1152) * refactor: rating (#1150) * refactor: sheet (#1149) * refactor: counter (#1136) * refactor: header & navigation menu (#1160) * fix: accordions props (#1162) * fix: remove transparent overlay prop in Sheet (#1163) * fix: gallery props (#1164) * feat: add pageSize prop to carousels (#1165) * chore: add changeset * chore: update changeset * fix: missing padding for sm viewport in quick search * fix: close mobile nav on navigation * fix: add aria-label to account tabs * fix: skip blog post card regression * fix: p wrapper for cart link * fix: update header visual regression test * fix: correct capitlization for tabs * fix: change hover for on click in test * fix: swatch test * fix: changeset examples * feat: add label prop to tabs * fix: update account and register spec * fix: update tests with latest changes --------- Co-authored-by: Matthew Volk <matt.volk@bigcommerce.com> Co-authored-by: Drew Pledger <drew@makeswift.com> Co-authored-by: Daniel Almaguer <daniel.almaguer@bigcommerce.com> Co-authored-by: Matthew Volk <volkmattj@gmail.com> Co-authored-by: Anudeep Vattipalli <anudeep.vattipalli@bigcommerce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Testing
Locally