Skip to content

Comments

adding Fastq.convertTo(FastqVariant) and supporting methods#28

Merged
andreasprlic merged 1 commit intobiojava:masterfrom
heuermh:fastq-convert
Nov 3, 2015
Merged

adding Fastq.convertTo(FastqVariant) and supporting methods#28
andreasprlic merged 1 commit intobiojava:masterfrom
heuermh:fastq-convert

Conversation

@heuermh
Copy link
Member

@heuermh heuermh commented Sep 25, 2015

Adds support for explicit conversions, e.g.

// illumina --> sanger variant conversion
FastqReader reader = new IlluminaFastqReader();
FastqWriter writer = new SangerFastqWriter();
FileWriter fileWriter = new FileWriter(new File("sanger.fastq"));

for (Fastq fastq : reader.read(new File("illumina.fastq")))) {
  writer.append(fileWriter, fastq.convertTo(FastqVariant.FASTQ_SANGER));
}

Companion pull request to biojava/biojava#334. As it is not convenient to use both 4.x and 1.x versions of biojava in the same codebase, the code in this package is mostly duplicated, org.biojava.bio.program.fastq here and org.biojava.nbio.sequencing.io.fastq in 4.x.

@heuermh
Copy link
Member Author

heuermh commented Nov 2, 2015

@andreasprlic could I get this merged? The companion pull request biojava/biojava#334 has been. Thanks!

andreasprlic added a commit that referenced this pull request Nov 3, 2015
adding Fastq.convertTo(FastqVariant) and supporting methods
@andreasprlic andreasprlic merged commit 0a9b2f9 into biojava:master Nov 3, 2015
@andreasprlic
Copy link
Member

sorry, missed this one.

@heuermh
Copy link
Member Author

heuermh commented Nov 3, 2015

No problem, thank you, Andreas!

@heuermh heuermh deleted the fastq-convert branch November 3, 2015 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants