Editing of ChunkedSymbolList plus tests.#32
Merged
heuermh merged 2 commits intobiojava:masterfrom Apr 26, 2016
Merged
Conversation
| cs.firePreChangeEvent(cevt); | ||
|
|
||
| // now for the edit | ||
| int posRightFragInSourceArray5 = edit.pos + edit.length - 1; |
Member
There was a problem hiding this comment.
is the 5 at the end of this variable name on purpose?
Contributor
Author
There was a problem hiding this comment.
Variable names taken from the Edit method of SimpleSymbolList.
Member
There was a problem hiding this comment.
Hey look at that, you're right! Must have been some odd copy and paste error originally. Feel free to commit a fix in both places and squash on this pull request or I can do it later.
Member
|
LGTM, with a few minor style fixes |
Member
|
Thanks @gwaldon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.