Skip to content

BIP 144: Segregated Witness (Peer Services)#272

Merged
luke-jr merged 10 commits intobitcoin:masterfrom
CodeShark:segwit_peer_services
Jan 8, 2016
Merged

BIP 144: Segregated Witness (Peer Services)#272
luke-jr merged 10 commits intobitcoin:masterfrom
CodeShark:segwit_peer_services

Conversation

@CodeShark
Copy link
Copy Markdown
Contributor

Needs BIP number

@btcdrak
Copy link
Copy Markdown
Contributor

btcdrak commented Jan 7, 2016

Looks like "spellcheck as you type" was enabled when creating the diagram giving the squiggly red lines.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please, consider using the services bit. Implementation wise, a client wanting to connect to a segwit supported node, don't want the need to wait for a magic timeout period to know if the node support segwit before trying the next one.

Using a message 'havewitness' will make peer discovery magnitude time longer.

@luke-jr luke-jr self-assigned this Jan 8, 2016
@luke-jr luke-jr changed the title Segwit peer services BIP 144: Segregated Witness (Peer Services) Jan 8, 2016
@luke-jr luke-jr merged commit d0ad38f into bitcoin:master Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants