BIP-{383,386,389,390}: fix small issues and discrepancies - #2239
Merged
Conversation
In BIP380 the capital letter H is explicitly defined as an invalid indicator for a hardened step. The "Invalid expression" section has explicit examples prefixed "Invalid hardened indicators" that show "0H/0H/0H" as being wrong.
A stray space is not allowed inside such an expression.
New BIPs with more allowed expressions within a tr() tree have been added and are worth mentioning.
The "15 compressed public keys" rule is not very precise and doesn't mention uncompressed ones. Core implements this differently as well: https://github.com/bitcoin/bitcoin/blob/master/src/script/descriptor.cpp#L2425 So we make the definition more precise.
Member
|
ACK 19d6e7f |
jonatack
added
Proposed BIP modification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some small problems and contradictions in the Output Descriptors BIPs while implementing a Golang version.