Skip to content

Fix: japanese words#685

Closed
dongri wants to merge 1 commit intobitcoin:masterfrom
huatuoxyz:master
Closed

Fix: japanese words#685
dongri wants to merge 1 commit intobitcoin:masterfrom
huatuoxyz:master

Conversation

@dongri
Copy link
Copy Markdown

@dongri dongri commented May 28, 2018

Change Japanese word

like だ ->

irb(main):003:0> "だ".bytesize
=> 6
irb(main):004:0> "だ".bytesize
=> 3
irb(main):005:0> 

@dabura667
Copy link
Copy Markdown

Please read the BIP.

All wordlists must be unicode NFKD normalized.

NFKD正規化された状態で単語リストを保有しないとバグ出ますよ。お気をつけて下さい。

@dabura667
Copy link
Copy Markdown

NACK

@dongri
Copy link
Copy Markdown
Author

dongri commented May 28, 2018

@dongri
Copy link
Copy Markdown
Author

dongri commented May 28, 2018

oh...
I misunderstood the specification.

@dongri dongri closed this May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants