Skip to content

add more tests for leading zero#905

Closed
klim0v wants to merge 2 commits intobitcoin:masterfrom
klim0v:patch-1
Closed

add more tests for leading zero#905
klim0v wants to merge 2 commits intobitcoin:masterfrom
klim0v:patch-1

Conversation

@klim0v
Copy link
Copy Markdown

@klim0v klim0v commented Apr 4, 2020

In the library btcsuite/btcutil and decred/dcrd all the tests that are listed here pass successfully, but there is an error on my case.

seed: "57fb1e450b8afb95c62afbcd49e4100d6790e0822b8905608679180ac34ca0bd45bf7ccc6c5f5218236d0eb93afc78bd117b9f02a6b7df258ea182dfaef5aad7", 
path: "m/44H/60H/0H",
want pub: "xpub6CpsfWjghR6XdCB8yDq7jQRpRKEDP2LT3ZRUgURF9g5xevB7YoTpogkFRqq5nQtVSN8YCMZo2CD8u4zCaxRv85ctCWmzEi9gQ5DBhBFaTNo", 
want priv: "xprv9yqXG1Cns3YEQi6fsCJ7NGV5sHPiyZcbgLVst61dbLYyn7qy1G9aFtRmaYp481ounqnVf9Go2ymQ4gmxZLEwYSRhU868aDk4ZxzGvqJVH"

The correction and discussion can be found here btcsuite/btcutil#161

In the library https://github.com/btcsuite/btcutil and https://github.com/decred/dcrd all the tests that are listed here pass successfully, but there is an error on my case. Seed: "57fb1e450b8afb95c62afbcd49e4100d6790e0822b8905608679180ac34ca0bd45bf7ccc6c5f5218236d0eb93afc78bd117b9f02a6b7df258ea182dfaef5aad7", want pub: "xpub6CpsfWjghR6XdCB8yDq7jQRpRKEDP2LT3ZRUgURF9g5xevB7YoTpogkFRqq5nQtVSN8YCMZo2CD8u4zCaxRv85ctCWmzEi9gQ5DBhBFaTNo", want priv: "xprv9yqXG1Cns3YEQi6fsCJ7NGV5sHPiyZcbgLVst61dbLYyn7qy1G9aFtRmaYp481ounqnVf9Go2ymQ4gmxZLEwYSRhU868aDk4ZxzGvqJVH". The correction and discussion can be found here btcsuite/btcutil#161
@klim0v
Copy link
Copy Markdown
Author

klim0v commented Apr 7, 2020

@luke-jr

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Apr 30, 2020

This needs @sipa, not me

@sipa
Copy link
Copy Markdown
Member

sipa commented Apr 30, 2020

@klim0v Does btcutil not fail the existing test vector 3? If not, in what way does this one differ?

If we're adding this, please make it a test vector 4 rather than squishing it into vector 3.

@klim0v
Copy link
Copy Markdown
Author

klim0v commented May 21, 2020

@sipa

@fametrano
Copy link
Copy Markdown
Contributor

NACK
Unless I am missing something, a library not failing at test vector #3 would not fail at this new proposed case:
e.g. see btclib-org/btclib@0cab434

@kallewoof
Copy link
Copy Markdown
Contributor

Is this resolved and can be closed, or is there still an issue that needs addressing?

@klim0v klim0v closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants