contrib/verifybinaries: allow filtering by platform#10276
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 22, 2017
Merged
contrib/verifybinaries: allow filtering by platform#10276laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
knocte
force-pushed
the
filterByPlatformInVerifySh
branch
2 times, most recently
from
33fd0da to
df77917
Compare
Member
|
Concept ACK, seems useful. |
Contributor
|
Concept ACK |
Member
|
Just tested this. Found one issue: looks like the script hangs indefinitely when providing an argument that doesn't match any files. |
Contributor
Author
|
I'll fix it, thanks for the feedback. |
Downloading all the binaries of all platforms can take quite long, especially for slow connections, which may deter people from using this script and, therefore, to disregard security altogether. This change introduces the new possibility of specifying the platform along with the version number, so that only the binaries that contain the platform name are downloaded.
knocte
force-pushed
the
filterByPlatformInVerifySh
branch
from
df77917 to
8d4dafd
Compare
Contributor
Author
|
Updated: if a platform name is provided that doesn't match any files, it will fail now with an error instead of hanging. NB: I don't know why the windows travis-CI build failed, looks unrelated to this... |
Member
|
ACK 8d4dafd |
laanwj
added a commit
that referenced
this pull request
Jun 22, 2017
8d4dafd contrib/verifybinaries: allow filtering by platform (Andres G. Aragoneses) Tree-SHA512: 5c117d18fd6e73cdbbf39c610f521bccb32ca7100eb8d5d5ed9c664514c37b32bd2f94f357b64c34f7c093e0c09312ecff330b7f5c708700d4b48643780ebac5
Member
|
ACK 8d4dafd |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 11, 2019
8d4dafd contrib/verifybinaries: allow filtering by platform (Andres G. Aragoneses) Tree-SHA512: 5c117d18fd6e73cdbbf39c610f521bccb32ca7100eb8d5d5ed9c664514c37b32bd2f94f357b64c34f7c093e0c09312ecff330b7f5c708700d4b48643780ebac5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloading all the binaries of all platforms can take quite long,
especially for slow connections, which may deter people from using
this script and, therefore, to disregard security altogether.
This change introduces the new possibility of specifying the
platform along with the version number, so that only the binaries
that contain the platform name are downloaded.