[qa] Bugfix: allow overriding extra_args in ComparisonTestFramework#10690
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jun 28, 2017
Merged
Conversation
Contributor
|
Tested ACK 4ed3653 |
Member
|
utACK 4ed3653 (I'm surprised the test was not failing with the wrong command line) |
Member
Author
So was I! That test needs to be overhauled in general though, as it makes no sense now that BIP65 activates on a specific height. |
Member
|
utACK 4ed3653 |
maflcko
pushed a commit
that referenced
this pull request
Jun 28, 2017
…estFramework 4ed3653 [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (Suhas Daftuar) Tree-SHA512: d8f724b3324aad73a7b15cf87ff394e8d615bf3cd5a394d5715347d833f2ae9ac745a944202986866255eca5fc105ea06ab3abe12e168b67de34482f751c68e2
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jun 23, 2019
…arisonTestFramework 4ed3653 [qa] Bugfix: allow overriding extra_args in ComparisonTestFramework (Suhas Daftuar) Tree-SHA512: d8f724b3324aad73a7b15cf87ff394e8d615bf3cd5a394d5715347d833f2ae9ac745a944202986866255eca5fc105ea06ab3abe12e168b67de34482f751c68e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that bip65-cltv-p2p.py was setting extra_args, but the ComparisonTestFramework was silently ignoring it. Though I think this framework is likely going to be decommissioned, this is easy enough to fix for now.