Skip to content

Trivial: Properly comment about shutdown process in init.cpp file.#10691

Merged
maflcko merged 1 commit intobitcoin:masterfrom
wraith7:master
Sep 12, 2017
Merged

Trivial: Properly comment about shutdown process in init.cpp file.#10691
maflcko merged 1 commit intobitcoin:masterfrom
wraith7:master

Conversation

@wraith7
Copy link
Copy Markdown
Contributor

@wraith7 wraith7 commented Jun 28, 2017

No description provided.

@jonasschnelli
Copy link
Copy Markdown
Contributor

ACK d7f8a6f1799076125827749ea61f0abbce201e7d
ultra nit: start a sentence with "And then"

Comment thread src/init.cpp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo in thread

@fanquake
Copy link
Copy Markdown
Member

fanquake commented Jul 6, 2017

Please squash into a single commit.

@wraith7
Copy link
Copy Markdown
Contributor Author

wraith7 commented Jul 6, 2017

Squashed

@maflcko maflcko merged commit 581c411 into bitcoin:master Sep 12, 2017
maflcko pushed a commit that referenced this pull request Sep 12, 2017
…t.cpp file.

581c411 Properly comment about shutdown process in init.cpp file (Kyuntae Ethan Kim)

Pull request description:

Tree-SHA512: 8aaf739ca5eb2cf6f777b69a0d65f391ba311a33d2e23abc4d3008f90c6ef9da79d0683845abfc08978309f43409f0a7021663f8c564e157224c1dbe15138158
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 10, 2020
… in init.cpp file.

581c411 Properly comment about shutdown process in init.cpp file (Kyuntae Ethan Kim)

Pull request description:

Tree-SHA512: 8aaf739ca5eb2cf6f777b69a0d65f391ba311a33d2e23abc4d3008f90c6ef9da79d0683845abfc08978309f43409f0a7021663f8c564e157224c1dbe15138158
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 7, 2020
…init.cpp file.

Summary:
581c411 Properly comment about shutdown process in init.cpp file (Kyuntae Ethan Kim)

Pull request description:

---

Backport of Core [[bitcoin/bitcoin#10691 | PR10691]]

Test Plan:
  read the comment

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D7791
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants