Merged
Conversation
Checks for setting the value, max length and reserved characters
mess110
force-pushed
the
test_uacomment
branch
from
898f720 to
c5dfa90
Compare
Member
|
utACK c5dfa90, thanks for adding tests! |
Contributor
|
Nice. Missing one test with multiple |
Contributor
Author
|
@promag by default test nodes have 1 uacomment set which I test here: https://github.com/bitcoin/bitcoin/pull/11486/files#diff-9bf941056cb812e87bf8826dd7a34952R18 and the following test checks for 2 uacomments (default + foo) I can add another one if more people think it is needed, but for now, I think it is enough. Thanks for the review |
Contributor
|
Ahh yes, restart with extra args. utACK c5dfa90 then. |
Member
|
utACK c5dfa90 |
laanwj
added a commit
that referenced
this pull request
Oct 18, 2017
c5dfa90 [tests] Add uacomment tests (Cristian Mircea Messel) Pull request description: Checks for setting the value, max length and reserved characters Tree-SHA512: a62e2cf8e455a3cd3987c0855f7bfc49de47504c01263e3573366e3cbff400c5678224773d4f1e4ac684fff34d987994e490a0978c4da05ff2a4bfa972c84723
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 16, 2020
c5dfa90 [tests] Add uacomment tests (Cristian Mircea Messel) Pull request description: Checks for setting the value, max length and reserved characters Tree-SHA512: a62e2cf8e455a3cd3987c0855f7bfc49de47504c01263e3573366e3cbff400c5678224773d4f1e4ac684fff34d987994e490a0978c4da05ff2a4bfa972c84723
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 30, 2021
c5dfa90 [tests] Add uacomment tests (Cristian Mircea Messel) Pull request description: Checks for setting the value, max length and reserved characters Tree-SHA512: a62e2cf8e455a3cd3987c0855f7bfc49de47504c01263e3573366e3cbff400c5678224773d4f1e4ac684fff34d987994e490a0978c4da05ff2a4bfa972c84723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for setting the value, max length and reserved characters