Skip to content

Add /bin/sh to bitcoin-qt.pro - as some filesystems don't have the execute flag.#1333

Merged
laanwj merged 1 commit intobitcoin:masterfrom
rebroad:AddBinSh
May 17, 2012
Merged

Add /bin/sh to bitcoin-qt.pro - as some filesystems don't have the execute flag.#1333
laanwj merged 1 commit intobitcoin:masterfrom
rebroad:AddBinSh

Conversation

@rebroad
Copy link
Copy Markdown
Contributor

@rebroad rebroad commented May 17, 2012

genbuild.sh will not run when used on filesystems without the execute flag for files. This is the only thing so far which causes make to fail in this situation, so an easy fix to restore functionality.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented May 17, 2012

ACK

BTW, wouldnt't the same be needed in the other makefiles?

@rebroad
Copy link
Copy Markdown
Contributor Author

rebroad commented May 17, 2012

@laanwj maybe... I'll track them down as add to this commit, shall I?

@rebroad
Copy link
Copy Markdown
Contributor Author

rebroad commented May 17, 2012

@laanwj ok, other Makefiles also updated. Thanks for pointing this out.

laanwj added a commit that referenced this pull request May 17, 2012
Add /bin/sh to bitcoin-qt.pro - as some filesystems don't have the execute flag.
@laanwj laanwj merged commit ae2fe47 into bitcoin:master May 17, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
Add /bin/sh to bitcoin-qt.pro - as some filesystems don't have the execute flag.
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request May 6, 2020
ebbb876 Peer initialization issues, bitcoin#8392 backport (furszy)

Pull request description:

  Upstream@[8392](bitcoin#8392) backport.

ACKs for top commit:
  random-zebra:
    ACK ebbb876
  Mrs-X:
    utACK PIVX-Project@ebbb876

Tree-SHA512: 4abe3200e5b883df925f3144e22368d48569a25364b60ae63ade9ed4d4d66da759a7b427be8460bb6999342ca3fcb4653cbe5c93fc4da7f6843fab3bb1400ce7
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants