Skip to content

GUI: update info strings for generated blocks#1412

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:string_wait_mature
Jun 12, 2012
Merged

GUI: update info strings for generated blocks#1412
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:string_wait_mature

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Jun 3, 2012

  • change "must wait" into "must mature" to take the new immature label into consideration
  • change "will be available in %n more blocks" into "matures in %n more block(s)"
  • remove ugly spaces from string

@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Jun 8, 2012

As @laanwj is currently not here that frequently it would be nice to have some other dev, who ACKs on small GUI changes like this one :).

Comment thread src/qt/transactiontablemodel.cpp Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has potential to confuse people. How about "Mined balance will be available when it matures in %n more block(s)"?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds better, will update!

… into "must mature" to take the new immature label into consideration
@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Jun 8, 2012

Updated to reflect lukes suggestion.

laanwj added a commit that referenced this pull request Jun 12, 2012
GUI: update info strings for generated blocks
@laanwj laanwj merged commit b6ef8d5 into bitcoin:master Jun 12, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
GUI: update info strings for generated blocks
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Jan 22, 2019
* make a link to forks.csv

* fix guide link
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request May 6, 2020
…transactions tests

10c896b [Tests][Cleanup] Remove wallet_resendwallettransactions (random-zebra)
9035fad [Tests][Cleanup] wallet_basic: remove walletbroadcast testing (random-zebra)

Pull request description:

  `walletbroadcast` is not available in our sources.
  There is no need to perform these checks in `wallet_basic` (which, aside from being buggy, include several slow operations, such as restarts and syncs).
  Average test time is lowered from 1155 to 833 seconds.

  Also remove `wallet_resendwallettransactions.py` as there is no such RPC in our code (the test was already disabled in the test_runner).

ACKs for top commit:
  Fuzzbawls:
    ACK 10c896b

Tree-SHA512: 3b98958ecd3356c8cd062191d708492dc82f2e25275a556e9b79fa1e8d83d08733d45c40e36dadc404b3daf1d3e335c84add9d5bfdb7bbc2409e64c357570286
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants