[WIP] docs: improve linux tar packages#14167
Closed
cisba wants to merge 3 commits intobitcoin:masterfrom
Closed
Conversation
Contributor
cisba
commented
Sep 7, 2018
cisba
commented
- README.md main file placed inside share/doc/bitcoin lsb directory
- Updated README.md to include link to repo, files list and description
- Added example bitcoin.conf, init files for daemon, RPCAuth Tool
This fixes bitcoin#8160 (partially), fixes bitcoin#8161, see also PR bitcoin#11971 and bitcoin#14022
cisba
changed the title
fanquake
changed the title
randolf
approved these changes
Sep 10, 2018
laanwj
reviewed
Sep 10, 2018
| find ${DISTNAME} -name "*.dbg" | sort | tar --no-recursion --mode='u+rw,go+r-w,a+X' --owner=0 --group=0 -c -T - | gzip -9n > ${OUTDIR}/${DISTNAME}-${i}-debug.tar.gz | ||
| DOCDISTNAME="${DISTNAME}/share/doc/bitcoin" | ||
| mkdir -p ${DOCDISTNAME}/init | ||
| cp ../doc/README.md ${DOCDISTNAME} |
Member
There was a problem hiding this comment.
I think the goal of putting the README.md in the root was to make it easy to find for someone extracting it
If you move it to share/doc/bitcoin, well, you might as well make it part of the general make install logic in the build system.
DocOBITCOIN
approved these changes
Sep 30, 2018
Member
|
@cisba What's the status of this PR, is it still a work in progress? Can you squash to remove the merge commits. |
Member
|
Closing "Up for grabs". Comment if you'd like this re-opened. |
Contributor
Author
Contributor
Author
I committed changes. Sorry for delay. Family and job came first. :) |
Contributor
Author
|
Please @fanquake re-open it. |
Member
|
@cisba just open a fresh pull request. This one cannot be reopened because the branch has been rewritten (force-pushed) |
cisba
added a commit
to cisba/bitcoin
that referenced
this pull request
Mar 7, 2019
Fix something missing from binary tar file: - Updated README.md to include link to repo, files list and description - Added example bitcoin.conf, init files for daemon, RPCAuth Tool - All files placed inside share/doc/bitcoin (lsb structure) using the general make install logic in the build system This is a rebasing of PR bitcoin#14167
Contributor
Author
cisba
added a commit
to cisba/bitcoin
that referenced
this pull request
Mar 9, 2019
Fix something missing from binary tar file:
- Updated README.md to include link to repo, files list and description
- Added example bitcoin.conf, init files for daemon, RPCAuth Tool
- All files placed inside share/doc/bitcoin (lsb structure)
using the general make install logic in the build system
This is a rebasing of PR bitcoin#14167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.