mempool: Document unsigned integer wraparounds in CTxMemPoolEntry::UpdateAncestorState(...)#14218
Closed
practicalswift wants to merge 1 commit intobitcoin:masterfrom
Closed
Conversation
…dateAncestorState(...)
maflcko
reviewed
Sep 14, 2018
| { | ||
| // An unsigned integer wraparound may take place here (modifySize is allowed to be negative). | ||
| nSizeWithAncestors += modifySize; | ||
| assert(int64_t(nSizeWithAncestors) > 0); |
Member
There was a problem hiding this comment.
I don't think this can wrap around in normal operation, since it is always first increased by some modifySize and only later reduced by the same modifySize.
Also, note the assert, which would be hit if a wraparound occurs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document unsigned integer wraparounds in
CTxMemPoolEntry::UpdateAncestorState(...).