Docs: correction to test readme compile instructions#14610
Closed
JBaczuk wants to merge 1 commit intobitcoin:masterfrom
Closed
Docs: correction to test readme compile instructions#14610JBaczuk wants to merge 1 commit intobitcoin:masterfrom
JBaczuk wants to merge 1 commit intobitcoin:masterfrom
Conversation
Member
|
Our compile tooling will notice that only test files have been modified and thus |
Contributor
Author
|
I'm just confused because it says, "If you modify a non-test file, use Wouldn't that only compile test files? |
Member
|
@JBaczuk And all core files needed to run those tests. Make reasons about dependencies. But it won't bother building the |
Contributor
Author
|
@sipa Ah, ok, sounds like I'm mistaken, then, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this wording is just switched, but correct me if I'm wrong. If you have only changed a test file, you can just build the files in the test folder, no need to build the entire source.