Skip to content

Docs: correction to test readme compile instructions#14610

Closed
JBaczuk wants to merge 1 commit intobitcoin:masterfrom
JBaczuk:fix_test_readme_compile_instructions
Closed

Docs: correction to test readme compile instructions#14610
JBaczuk wants to merge 1 commit intobitcoin:masterfrom
JBaczuk:fix_test_readme_compile_instructions

Conversation

@JBaczuk
Copy link
Copy Markdown
Contributor

@JBaczuk JBaczuk commented Oct 30, 2018

I'm pretty sure this wording is just switched, but correct me if I'm wrong. If you have only changed a test file, you can just build the files in the test folder, no need to build the entire source.

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Oct 30, 2018

Our compile tooling will notice that only test files have been modified and thus make will only compile the test files if they have been modified, so the wording as in master sounds correct to me.

@fanquake fanquake added the Docs label Oct 30, 2018
@JBaczuk
Copy link
Copy Markdown
Contributor Author

JBaczuk commented Nov 1, 2018

I'm just confused because it says, "If you modify a non-test file, use make -C src/test to recompile only what's needed to run the bitcoind tests."

Wouldn't that only compile test files?

@sipa
Copy link
Copy Markdown
Member

sipa commented Nov 1, 2018

@JBaczuk And all core files needed to run those tests. Make reasons about dependencies.

But it won't bother building the bitcoind binary, which isn't needed for the unit tests.

@JBaczuk
Copy link
Copy Markdown
Contributor Author

JBaczuk commented Nov 1, 2018

@sipa Ah, ok, sounds like I'm mistaken, then, thanks.

@JBaczuk JBaczuk closed this Nov 1, 2018
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants