Skip to content

build: Drop AC_CHECK_DECLS for unused __builtin_clz#14747

Closed
Empact wants to merge 1 commit intobitcoin:masterfrom
Empact:builtin-clz
Closed

build: Drop AC_CHECK_DECLS for unused __builtin_clz#14747
Empact wants to merge 1 commit intobitcoin:masterfrom
Empact:builtin-clz

Conversation

@Empact
Copy link
Copy Markdown
Contributor

@Empact Empact commented Nov 17, 2018

__builtin_clz has never been used, decl check introduced in 4fd2d2f

@gmaxwell
Copy link
Copy Markdown
Contributor

@Empact
Copy link
Copy Markdown
Contributor Author

Empact commented Nov 17, 2018

I see clzl and clzll are used, but not clz.

@DrahtBot
Copy link
Copy Markdown
Contributor

Gitian builds for commit 3573997 (master):

Gitian builds for commit 5c83b871e312935550ca6c3c9f655209e99deeaa (master and this pull):

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Nov 21, 2018

~0 from me, it's somewhat likely clz will come in useful some time in the future

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Nov 22, 2018

Too controversial for a trivial change. Closing for now.

@maflcko maflcko closed this Nov 22, 2018
@Empact Empact deleted the builtin-clz branch November 25, 2018 02:52
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants