-wallet is a "network-only" option but -walletdir is not

[maflcko]

Any reason for this?

bitcoin/src/util/system.cpp

Lines 316 to 326 in 2d46f1b

	/* These options would cause cross-contamination if values for
	* mainnet were used while running on regtest/testnet (or vice-versa).
	* Setting them as section_only_args ensures that sharing a config file
	* between mainnet and regtest/testnet won't cause problems due to these
	* parameters by accident. */
	m_network_only_args{
	"-addnode", "-connect",
	"-port", "-bind",
	"-rpcport", "-rpcbind",
	"-wallet",
	}

[promag]

#11862 (Network specific conf sections) came after #11466 (Specify custom wallet directory with -walletdir param) and in #11862 -walletdir is never mentioned.

I think it makes sense to add -walletdir.

[luke-jr]

It's not inherently broken to put wallets for different networks in the same directory, so it makes sense to allow a shared -walletdir...

[promag]

@luke-jr but wallets are relative to -walletdir so it could be confusing no?

[luke-jr]

Maybe. I suppose without -walletdir we do have network-separate wallet dirs.

[maflcko]

See also discussion in " Wallet file should not be reused across chains #12805 "

[hebasto]

@MarcoFalke @meshcollider
Could this issue also be labeled "Wallet"?