refactor: small optimization for IsHex method

[shargon]

In case the condition is false, every character is checked first. This operation is not necessary.

If you call the method with a truncated hex string, you will loose performance. The last check will be done, so is better to do it the first one

[fanquake]

Please fix your commit messages and remove the merge commit.

As this is an optimization, please also provide benchmarks.

[promag]

This change supposedly optimizes the false case, I don't think it matters.

[jcliff]

+1 to @fanquake's recommendation for squashing the commits and fixing the commit message to be clearer.

@fanquake, @promag, This change clearly avoids computation in some cases without adding complexity.

[promag]

This change clearly avoids computation in some cases without adding complexity.

@jcliff and in other cases adds more "computation". I suspect a benchmark would give similar results, and in that case why bother?

[laanwj]

Is there any user-visible (or, network-visible) behavior that this would speed up?

Thank you for your first contribution, but we're kind of strict in this project as to requiring a strong rationale for every change. It takes effort to review a change, and there's always a risk.

[laanwj]

Closing this, sorry, there is no agreement to do this