build: organize tests by goal#17558
Closed
RandyMcMillan wants to merge 2 commits intobitcoin:masterfrom
RandyMcMillan:2019/325/order-by-goal
Closed
build: organize tests by goal#17558RandyMcMillan wants to merge 2 commits intobitcoin:masterfrom RandyMcMillan:2019/325/order-by-goal
RandyMcMillan wants to merge 2 commits intobitcoin:masterfrom
RandyMcMillan:2019/325/order-by-goal
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests can be organized by goal for efficiency and clarity.
deployis beforeinstallbecause this stage is fasterand if it fails - it eliminates the need to continue - which is a
positive for jobs waiting in the cue.
There are other ways to improve efficiency but this one seemed easy
to implement with minimal changes to the .travis.yml configuration.