Skip to content

gui: increases default GraphRange of Network Traffic to 12 hours.#17645

Closed
arscynic wants to merge 1 commit intobitcoin:masterfrom
arscynic:GraphRange
Closed

gui: increases default GraphRange of Network Traffic to 12 hours.#17645
arscynic wants to merge 1 commit intobitcoin:masterfrom
arscynic:GraphRange

Conversation

@arscynic
Copy link
Copy Markdown

@arscynic arscynic commented Dec 1, 2019

  1. A graph range of 12 h shows a more informative overview of the daily traffic.
  2. It's annoying to increase this range after every reboot; 12 hours is right in the middle, so users who want to change it have to drag the slider less compared to the original value.

Value 6 = 30 minutes (6 * 5 m), value 144 = 12 hours (144 * 5 m).

@fanquake fanquake added the GUI label Dec 1, 2019
@chris-belcher
Copy link
Copy Markdown
Contributor

Concept ACK

@arscynic
Copy link
Copy Markdown
Author

arscynic commented Dec 1, 2019

No idea what caused this error.
I edited the value in Visual Studio Code and saved it. This is the console output during the process: https://pastebin.com/FCCEHdjt. You can see I initially merged the branch to my master and pushed it, instead of pushing the branch directly—which I did afterward.

@jonasschnelli
Copy link
Copy Markdown
Contributor

Unsure about this...

  1. Running this commit, the initial displayed value is 30min, when I slider forth and back to the same position, it states 12h (bug).
  2. Using a 12h window makes the graph black for a minute or so (including the grid) which is non-ideal for a user feedback (probably acceptable since not directly related to this change).

@arscynic
Copy link
Copy Markdown
Author

arscynic commented Dec 1, 2019

@jonasschnelli
To be a nitpicker:

  1. 30 m and 12 h [in case someone tries to ctrl+f 'min']
  2. ~53 seconds.

Anyway, I agree that both consequences are annoying; the former being unacceptable.

@hebasto
Copy link
Copy Markdown
Member

hebasto commented Dec 7, 2019

  • Using a 12h window makes the graph black for a minute or so (including the grid) which is non-ideal for a user feedback (probably acceptable since not directly related to this change).

This behavior is observed on master branch too.

MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Dec 17, 2019
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Mar 27, 2020

There doesn't seem to be agreement on doing this and the PR has been inactive for months, closing.

@laanwj laanwj closed this Mar 27, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants