doc: use recommended shebang approach in documentation code block#17751
Merged
maflcko merged 1 commit intobitcoin:masterfrom Dec 20, 2019
Merged
doc: use recommended shebang approach in documentation code block#17751maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
hackerrdave
force-pushed
the
docs-shebang
branch
from
2149885 to
1e5d6ad
Compare
promag
reviewed
Dec 17, 2019
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Have you searched for similar places were this change could be applied?
Contributor
Author
|
@promag Yea, the only other place I believe that this change could be applied is: https://github.com/bitcoin/bitcoin/blob/master/test/lint/lint-shell.sh#L54 I'll add that change as well |
hackerrdave
force-pushed
the
docs-shebang
branch
from
fcbfa25 to
e464145
Compare
Member
|
Please squash your commits. |
hackerrdave
force-pushed
the
docs-shebang
branch
from
e464145 to
e5e6c52
Compare
laanwj
reviewed
Dec 17, 2019
hackerrdave
force-pushed
the
docs-shebang
branch
from
e5e6c52 to
8dea322
Compare
hebasto
requested changes
Dec 17, 2019
hackerrdave
force-pushed
the
docs-shebang
branch
from
8dea322 to
6094222
Compare
maflcko
pushed a commit
that referenced
this pull request
Dec 20, 2019
…code block 6094222 use preferred shebang approach for documentation (hackerrdave) Pull request description: Documentation update to use recommended shebang approach mentioned in the [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#shebang) ACKs for top commit: hebasto: ACK 6094222, I have reviewed the code, and it looks OK, I agree it can be merged. Tree-SHA512: fc58632f0a6fa82c7abdddfac4897f082110d647426d2b468cba6fabf6b34a015fcad47e5b26be98e629b8b0417b8781e8d89da67189e20da228b97b17f1a532
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 20, 2019
…tation code block 6094222 use preferred shebang approach for documentation (hackerrdave) Pull request description: Documentation update to use recommended shebang approach mentioned in the [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#shebang) ACKs for top commit: hebasto: ACK 6094222, I have reviewed the code, and it looks OK, I agree it can be merged. Tree-SHA512: fc58632f0a6fa82c7abdddfac4897f082110d647426d2b468cba6fabf6b34a015fcad47e5b26be98e629b8b0417b8781e8d89da67189e20da228b97b17f1a532
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 9, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#17751 | PR17751]] Test Plan: Proof-reading Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8333
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…tation code block 6094222 use preferred shebang approach for documentation (hackerrdave) Pull request description: Documentation update to use recommended shebang approach mentioned in the [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#shebang) ACKs for top commit: hebasto: ACK 6094222, I have reviewed the code, and it looks OK, I agree it can be merged. Tree-SHA512: fc58632f0a6fa82c7abdddfac4897f082110d647426d2b468cba6fabf6b34a015fcad47e5b26be98e629b8b0417b8781e8d89da67189e20da228b97b17f1a532
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…tation code block 6094222 use preferred shebang approach for documentation (hackerrdave) Pull request description: Documentation update to use recommended shebang approach mentioned in the [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#shebang) ACKs for top commit: hebasto: ACK 6094222, I have reviewed the code, and it looks OK, I agree it can be merged. Tree-SHA512: fc58632f0a6fa82c7abdddfac4897f082110d647426d2b468cba6fabf6b34a015fcad47e5b26be98e629b8b0417b8781e8d89da67189e20da228b97b17f1a532
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 14, 2021
…tation code block 6094222 use preferred shebang approach for documentation (hackerrdave) Pull request description: Documentation update to use recommended shebang approach mentioned in the [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#shebang) ACKs for top commit: hebasto: ACK 6094222, I have reviewed the code, and it looks OK, I agree it can be merged. Tree-SHA512: fc58632f0a6fa82c7abdddfac4897f082110d647426d2b468cba6fabf6b34a015fcad47e5b26be98e629b8b0417b8781e8d89da67189e20da228b97b17f1a532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation update to use recommended shebang approach mentioned in the developer notes