Skip to content

remove init messages from ThreadImport()#1941

Merged
sipa merged 1 commit intobitcoin:masterfrom
Diapolo:rem_initMsg_main
Oct 21, 2012
Merged

remove init messages from ThreadImport()#1941
sipa merged 1 commit intobitcoin:masterfrom
Diapolo:rem_initMsg_main

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Oct 21, 2012

  • remove uiInterface.InitMessage() calls from ThreadImport(), as Qt
    doesn't like them getting called out of it's main thread and because the
    thread will continue to run after the GUI was loaded

This fixes a crash I discovered, while compiling Bitcoin-Qt the first time after Ultraprune was merged to master.

- remove uiInterface.InitMessage() calls from ThreadImport(), as Qt
  doesn't like them getting called out of it's main thread and because the
  thread will continue to run after the GUI was loaded
sipa added a commit that referenced this pull request Oct 21, 2012
remove init messages from ThreadImport()
@sipa sipa merged commit d44f1ea into bitcoin:master Oct 21, 2012
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Nov 5, 2012

You found a pretty bad bug there, good catch.

@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Nov 5, 2012

Thanks mate :).

laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
remove init messages from ThreadImport()
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants