Designer fees when coin control is enabled#20652
Closed
gbizzotto wants to merge 1 commit intobitcoin:masterfrom
Closed
Designer fees when coin control is enabled#20652gbizzotto wants to merge 1 commit intobitcoin:masterfrom
gbizzotto wants to merge 1 commit intobitcoin:masterfrom
Conversation
Fees can now be set in satoshis instead of kSat/kB only. Fees can now be set to zero satoshis. When switching to designer fee, or when inputs or outputs are changed, tx size is properly calculated (no guesswork). Fees, specified internally in sat/B, used to suffer alterations due to those approximations.
gbizzotto
changed the title
Contributor
|
GUI changes should be submitted in https://github.com/bitcoin-core/gui. |
Member
|
Also, make sure to run the test locally before submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement over current UI fee selection.
Current UI only allows kSat/kB fees, calculated over an approximation of the tx size.
Some users may want to set a specific fee in satoshis, including zero, which isn't possible.
This PR adds the UI items necessary for the user to set a specific fee.
Commit comment:
Fees can now be set in satoshis instead of kSat/kB only.
Fees can now be set to zero satoshis.
When switching to designer fee, or when inputs or outputs are changed, tx size is properly calculated (no guesswork). Fees, specified internally in sat/B, used to suffer alterations due to those approximations.