Do not call ResendWalletTransactions during reindex#2255
Closed
rdponticelli wants to merge 1 commit intobitcoin:masterfrom
Closed
Do not call ResendWalletTransactions during reindex#2255rdponticelli wants to merge 1 commit intobitcoin:masterfrom
rdponticelli wants to merge 1 commit intobitcoin:masterfrom
Conversation
Calling ResendWalletTransactions during a reindex spams other nodes with our old transactions, because they become unconfirmed.
Member
|
@rdponticelli: you can just push to a branch already associated with a pull request to update it. |
Contributor
Author
|
Yeah, I know. But that would have left 2 commits for a trivial change, right? Or a history rewrite, if I would have amended the commit, no problems with that? Anyway, I thought it would be cleaner this way... |
Member
|
Inside you own branches you can amend/rebase/rewrite as much as you want. In public branches such as bitcoin/bitcoin, it isn't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling ResendWalletTransactions during a reindex spams other
nodes with our old transactions, because they become unconfirmed.