Skip to content

doc: Add a brief overview of fuzzing/Bitcoin Core fuzzing#23482

Merged
maflcko merged 1 commit intobitcoin:masterfrom
agroce:patch-3
Nov 11, 2021
Merged

doc: Add a brief overview of fuzzing/Bitcoin Core fuzzing#23482
maflcko merged 1 commit intobitcoin:masterfrom
agroce:patch-3

Conversation

@agroce
Copy link
Copy Markdown
Contributor

@agroce agroce commented Nov 10, 2021

  • Google's repo
  • Our report
  • John's advice on fuzz-friendly development

- Google's repo
- Our report
- John's advice on fuzz-friendly development
@agroce
Copy link
Copy Markdown
Contributor Author

agroce commented Nov 10, 2021

attn @MarcoFalke and @practicalswift

@DrahtBot DrahtBot added the Docs label Nov 10, 2021
@laanwj laanwj added the Tests label Nov 10, 2021
@maflcko maflcko changed the title Add a brief overview of fuzzing/Bitcoin Core fuzzing doc: Add a brief overview of fuzzing/Bitcoin Core fuzzing Nov 10, 2021
@maflcko
Copy link
Copy Markdown
Member

maflcko commented Nov 10, 2021

ACK 6cac99a

Comment thread doc/fuzzing.md

## Overview of Bitcoin Core fuzzing

[Google](https://github.com/google/fuzzing/) has a good overview of fuzzing in general, with contributions from key architects of some of the most-used fuzzers. [This paper](https://agroce.github.io/bitcoin_report.pdf) includes an external overview of the status of Bitcoin Core fuzzing, as of summer 2021. [John Regehr](https://blog.regehr.org/archives/1687) provides good advice on writing code that assists fuzzers in finding bugs, which is useful for developers to keep in mind.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to start with the link to the report, as that's the section title, move the general advice later.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea; I went this way since the report assumes a good bit of fuzzing background, perhaps, and the Google link would be a better place to start from to understand it, but the ordering is a bit weird this way, maybe.

@brunoerg
Copy link
Copy Markdown
Contributor

Concept ACK.
I have been looking for docs to learn more about fuzzing, this is a good start.

@ghost
Copy link
Copy Markdown

ghost commented Nov 10, 2021

Concept ACK

Copy link
Copy Markdown
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6cac99a

The added documentation looks good and is quite helpful. Checked that the links are correct and direct to the right locations. There are also no grammatical mistakes in the added sentences (checked with Grammarly premium).
Thanks for this great work, @agroce!

@maflcko maflcko merged commit bc03823 into bitcoin:master Nov 11, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 11, 2021
…e fuzzing

6cac99a Add a brief overview of fuzzing/Bitcoin Core fuzzing (Alex Groce)

Pull request description:

  - Google's repo
  - Our report
  - John's advice on fuzz-friendly development

ACKs for top commit:
  MarcoFalke:
    ACK 6cac99a
  shaavan:
    ACK 6cac99a

Tree-SHA512: 45d1f2f49d068ddd40c3e60cb4a3ede079276e0e09328eec04e391637e9225e195dd7ee1573aa962a2cae93a7e432f9e1d5d0b97660b879ab37ce453cc43c275
@bitcoin bitcoin locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants