Skip to content

depends: use a patch instead of sed in libxcb#25738

Merged
fanquake merged 1 commit intobitcoin:masterfrom
fanquake:remove_sed_libxcb
Jul 30, 2022
Merged

depends: use a patch instead of sed in libxcb#25738
fanquake merged 1 commit intobitcoin:masterfrom
fanquake:remove_sed_libxcb

Conversation

@fanquake
Copy link
Copy Markdown
Member

To remove the unneeded pthread-stubs requirement.

Should almost be enough to close #16838.

seds dead (mostly). The usage left in qt.mk are for substituting runtime values.

To remove the unneeded pthread-stubs requirements.
@hebasto
Copy link
Copy Markdown
Member

hebasto commented Jul 29, 2022

Concept ACK.

Copy link
Copy Markdown
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f1ff48.

Using #21995, I've verified that package archive hashes are identical for builds with and without this PR. Also verified that the patch is being applied cleanly.

@fanquake fanquake merged commit 6745e36 into bitcoin:master Jul 30, 2022
@fanquake fanquake deleted the remove_sed_libxcb branch July 30, 2022 08:34
@hebasto
Copy link
Copy Markdown
Member

hebasto commented Jul 30, 2022

Using #21995, I've verified that package archive hashes are identical for builds with and without this PR.

@fanquake Mind looking into #21995?

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 1, 2022
8f1ff48 libxcb: use a patch instead of sed (fanquake)

Pull request description:

  To remove the unneeded pthread-stubs requirement.

  Should almost be enough to close bitcoin#16838.

  seds dead (mostly). The usage left in `qt.mk` are for substituting runtime values.

ACKs for top commit:
  hebasto:
    ACK 8f1ff48.

Tree-SHA512: 2b6ebbe98a838d8e08e54737292b02176ff4c85a541ae1ec0c590c75e33ba92289628b88ca3144f2e214f4327515f7fd22c39687312f44183b759815c092b24f
@bitcoin bitcoin locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

depends: sed robustness

2 participants