test: Add test for sendmany rpc that uses subtractfeefrom parameter#26733
Merged
achow101 merged 1 commit intobitcoin:masterfrom May 1, 2023
Merged
test: Add test for sendmany rpc that uses subtractfeefrom parameter#26733achow101 merged 1 commit intobitcoin:masterfrom
sendmany rpc that uses subtractfeefrom parameter#26733achow101 merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
brunoerg
reviewed
Dec 20, 2022
yusufsahinhamza
force-pushed
the
add-sendmany-test
branch
from
b395999 to
f3fab28
Compare
kiminuo
reviewed
Dec 30, 2022
kiminuo
reviewed
Dec 30, 2022
yusufsahinhamza
force-pushed
the
add-sendmany-test
branch
from
f3fab28 to
057057a
Compare
Member
|
ACK 057057a |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 1, 2023
…tractfeefrom` parameter 057057a Add test for `sendmany` rpc that uses `subtractfeefrom` parameter (Yusuf Sahin HAMZA) Pull request description: This PR adds test that uses `sendmany` rpc to send **BTC** to multiple addresses using `subtractfeefrom` parameter, then checks receiver addresses balances to make sure fees are subtracted correctly. ACKs for top commit: achow101: ACK 057057a Tree-SHA512: 51167120d489f0ff7b8b9855424d07cb55a8965984f904643cddf45e7a08c350eaded498c350ec9c660edf72c2f128ec142347c9c79d5043d9f6cd481b15cd7e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test that uses
sendmanyrpc to send BTC to multiple addresses usingsubtractfeefromparameter, then checks receiver addresses balances to make sure fees are subtracted correctly.