refactor: Make ThreadHTTP return void#26821
Merged
achow101 merged 1 commit intobitcoin:masterfrom Jan 11, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
brunoerg
approved these changes
Jan 5, 2023
w0xlt
approved these changes
Jan 5, 2023
stickies-v
approved these changes
Jan 11, 2023
Contributor
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
ACK 45553e1
I was wondering recently why we had this line. Bye!
Member
|
ACK 45553e1 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 12, 2023
45553e1 refactor: Make `ThreadHTTP` return void (Hennadii Stepanov) Pull request description: The `bool` return value was introduced in 755aa05 (bitcoin#8421). It has been not used since 8d3f46e (bitcoin#14670). No behavior change. ACKs for top commit: achow101: ACK 45553e1 brunoerg: crACK 45553e1 w0xlt: ACK bitcoin@45553e1 stickies-v: ACK 45553e1 Tree-SHA512: 1593a5740e729967fbe1363235cd5b77ecf431b29bc740a89a6c70fc838ad97a2e4a2cd7cd63aa482f7c50bc2ffabc8cd53e8f64d6032603cb3b662229bc3dc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
boolreturn value was introduced in 755aa05 (#8421).It has been not used since 8d3f46e (#14670).
No behavior change.