Skip to content

doc: update windows -fstack-clash-protection doc#28084

Merged
fanquake merged 1 commit intobitcoin:masterfrom
fanquake:stack_clash_windows_doc_update
Jul 17, 2023
Merged

doc: update windows -fstack-clash-protection doc#28084
fanquake merged 1 commit intobitcoin:masterfrom
fanquake:stack_clash_windows_doc_update

Conversation

@fanquake
Copy link
Copy Markdown
Member

Now that changes have been made in GCC, to fix the build failures.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90458.

Now that changes have been made in GCC, to fix the build failures.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90458.
@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Jul 16, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Jul 16, 2023
Copy link
Copy Markdown
Contributor

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 05ef059

Copy link
Copy Markdown
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 05ef059, I've verified that the fix commit is present in all branches starting from gcc-11.

@fanquake fanquake merged commit 275b3e4 into bitcoin:master Jul 17, 2023
@fanquake fanquake deleted the stack_clash_windows_doc_update branch July 17, 2023 12:14
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 17, 2023
05ef059 doc: update windows -fstack-clash-protection doc (fanquake)

Pull request description:

  Now that changes have been made in GCC, to fix the build failures.
  See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90458.

ACKs for top commit:
  TheCharlatan:
    ACK 05ef059
  hebasto:
    ACK 05ef059, I've verified that the fix commit is present in all branches starting from `gcc-11`.

Tree-SHA512: 96b79d65b46e6b9d939c8e6079e984da86987503210106d5155dbe5a6fd82d56d9983694656e27156b01bab795c766b85fc60c799813bc676bba5f3b73f9be22
@bitcoin bitcoin locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants