doc: correct Fedora systemtap dep#28110
Merged
fanquake merged 1 commit intobitcoin:masterfrom Jul 20, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 4, 2024
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Sep 5, 2024
, bitcoin#23302, bitcoin#22902, bitcoin#23724, bitcoin#26944, bitcoin#23907, bitcoin#24358, bitcoin#25360, bitcoin#25794, bitcoin#26945, bitcoin#27458, bitcoin#28110 (userspace static defined tracing) 0a7a234 merge bitcoin#28110: correct Fedora systemtap dep (Kittywhiskers Van Gogh) c92eb67 merge bitcoin#27458: Detect USDT the same way how it is used in the code (Kittywhiskers Van Gogh) f4a53ba merge bitcoin#26945: systemtap 4.8 (Kittywhiskers Van Gogh) 8869612 merge bitcoin#25794: don't rely on block_connected USDT event order in tests (Kittywhiskers Van Gogh) 457bbd3 merge bitcoin#25360: SystemTap 4.7 (RISC-V support) (Kittywhiskers Van Gogh) f3b219a merge bitcoin#24358: USDT tracepoint interface tests (Kittywhiskers Van Gogh) 5b10a5a merge bitcoin#23907: utxocache tracepoints follow up (Kittywhiskers Van Gogh) c3d7e3a merge bitcoin#26944: fix systemtap download URL (Kittywhiskers Van Gogh) 264e02f merge bitcoin#23724: add systemtap's sys/sdt.h as depends for GUIX builds with USDT tracepoints (Kittywhiskers Van Gogh) 6cc596b merge bitcoin#22902: utxocache tracepoints (Kittywhiskers Van Gogh) 644a47e merge bitcoin#23302: drop GetHash().ToString() argument from the `validation:block_connected` tracepoint (Kittywhiskers Van Gogh) bfdc9ad merge bitcoin#23375: more deterministic coin selection for coinbase UTXOs (oldest first) (Kittywhiskers Van Gogh) 5718716 merge bitcoin#22955: Rename fBlocksOnly, Add test (Kittywhiskers Van Gogh) cacc312 merge bitcoin#22006: first tracepoints and documentation on User-Space, Statically Defined Tracing (USDT) (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * In [bitcoin#22955](bitcoin#22955), `fBlocksOnly` has not been renamed to `reject_tx_invs` as Dash uses the inventory system beyond relaying transaction data with the block-relay-only blocklist have a greater set of prohibited messages. This renders the new name misleading but coining a new name may be a source of confusion, making retaining the legacy name desirable. * Additionally, because the word "transaction" isn't hardcoded into the log message (instead opting to use `CInv::GetCommand()`'s output instead, which for transactions, are "tx"), the expected log message in `p2p_blocksonly.py` has been adjusted accordingly. * [bitcoin#24358](bitcoin#24358) depends on [bitcoin#22955](bitcoin#22955) and [bitcoin#23375](bitcoin#23375) in order to work as without the latter backport, `interface_usdt_utxocache.py` will return the following error <details> <summary>Test run:</summary> ``` debian@debian:~/dash$ sudo ./test/functional/interface_usdt_utxocache.py [sudo] password for debian: 2024-08-26T17:08:05.234000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_n5rb0xy4 2024-08-26T17:08:07.023000Z TestFramework (INFO): testing the utxocache:uncache tracepoint API 2024-08-26T17:08:07.026000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/home/debian/dash/test/functional/test_framework/test_framework.py", line 160, in main self.run_test() File "/home/debian/dash/./test/functional/interface_usdt_utxocache.py", line 149, in run_test self.test_uncache() File "/home/debian/dash/./test/functional/interface_usdt_utxocache.py", line 172, in test_uncache invalid_tx = self.wallet.create_self_transfer( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/debian/dash/test/functional/test_framework/wallet.py", line 166, in create_self_transfer assert_equal(mempool_valid, tx_info['allowed']) File "/home/debian/dash/test/functional/test_framework/util.py", line 51, in assert_equal raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args)) AssertionError: not(True == False) 2024-08-26T17:08:07.533000Z TestFramework (INFO): Stopping nodes 2024-08-26T17:08:08.535000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_n5rb0xy4 2024-08-26T17:08:08.535000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_n5rb0xy4/test_framework.log 2024-08-26T17:08:08.535000Z TestFramework (ERROR): 2024-08-26T17:08:08.535000Z TestFramework (ERROR): Hint: Call /home/debian/dash/test/functional/combine_logs.py '/tmp/dash_func_test_n5rb0xy4' to consolidate all logs 2024-08-26T17:08:08.536000Z TestFramework (ERROR): 2024-08-26T17:08:08.536000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log. 2024-08-26T17:08:08.536000Z TestFramework (ERROR): https://github.com/dashpay/dash/issues 2024-08-26T17:08:08.536000Z TestFramework (ERROR): ``` </details> with the underlying error that has been alluded to in d2c4904 ``` {'txid': '44b58b10e69321dacf00724f1893c9ecb50fc1f89ed7c70a6c0b3c08f7dc750f', 'allowed': False, 'reject-reason': 'bad-txns-premature-spend-of-coinbase'} ``` * In [bitcoin#24358](bitcoin#24358), all `interface_usdt_*.py` tests needed minor syntax changes to account for how we invoke certain RPCs. `interface_usdt_utxocache.py` required tweaking with the blocks needed to be eligible for pruning (`450` vs. `350` upstream) and stop the node explicitly to account for the governance validation warning . This is important as the placement assumes that `test_flush()` is the last test, should this change, the node may need to be manually started before continuing on with the tests after. * Some `TRACE*` entries may not exactly match the backports they come from because the variables or functions they access may have been amended by a backport done _after_ the backport that introduce the trace entry. ## Breaking Changes None observed. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 0a7a234 PastaPastaPasta: utACK [0a7a234](0a7a234) Tree-SHA512: 8df11392dd8d152c18d55ac70a446d1eec336bdf1a984cbf41c3202c353358180e05ba4b7182ec2962ea09eefa41d1dc3cd383d358f9b3dec57ce8b67c6e6afd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.