Skip to content

fuzz: Avoid timeout in bitdeque#29012

Merged
fanquake merged 1 commit intobitcoin:masterfrom
maflcko:2312-fuzz-time-bitd-
Dec 6, 2023
Merged

fuzz: Avoid timeout in bitdeque#29012
fanquake merged 1 commit intobitcoin:masterfrom
maflcko:2312-fuzz-time-bitd-

Conversation

@maflcko
Copy link
Copy Markdown
Member

@maflcko maflcko commented Dec 6, 2023

Avoid timeouts such as #28812 (comment)

This is done by:

  • Limiting the maximum number of iterations if the maximum size of the container is "large" (see the magic numbers in the code).
  • Check the equality only once. This should be fine, because if a crash were to happen in the equality check, but the crash doesn't happen if further iterations were run, the fuzz engine should eventually find the crash by truncating the fuzz input.

@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Dec 6, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK sipa, dergoegge, brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Dec 6, 2023
@sipa
Copy link
Copy Markdown
Member

sipa commented Dec 6, 2023

utACK fad1903

Copy link
Copy Markdown
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK fad1903

Copy link
Copy Markdown
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK fad1903

@fanquake fanquake merged commit 2e8ec6b into bitcoin:master Dec 6, 2023
@maflcko maflcko deleted the 2312-fuzz-time-bitd- branch December 6, 2023 17:36
@bitcoin bitcoin locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants