Skip to content

Revert "Introduce g_fuzzing global for fuzzing checks"#31189

Closed
dergoegge wants to merge 1 commit intobitcoin:masterfrom
dergoegge:2024-10-revert-31093
Closed

Revert "Introduce g_fuzzing global for fuzzing checks"#31189
dergoegge wants to merge 1 commit intobitcoin:masterfrom
dergoegge:2024-10-revert-31093

Conversation

@dergoegge
Copy link
Copy Markdown
Member

Assume's should not be compiled in for production builds. #31093 broke that property of Assume.

Closes #31178

@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Oct 31, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@dergoegge
Copy link
Copy Markdown
Member Author

CI will fail and we'll probably need to reconsider #31057 and #31073

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Oct 31, 2024

It would be good to make it constexpr instead #31178 (comment) and use that to fix the issues. Happy to do it myself, but I think it should be part of one pull request. Otherwise you'll just switch one issue for another and a follow-up has to be created anyway.

@dergoegge
Copy link
Copy Markdown
Member Author

I don't think the approach described in #31178 (comment) would fix the ci issues? If we make it a compile time option we'll see the timeouts in p2p_headers_presync for the macos and windows CI either way.

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Oct 31, 2024

Yeah, I am saying that the fix should be a complete one, at least when it comes to the ./src directory. Otherwise it will have to be touched again. I am happy to submit a pull, or review one. But I think there have been enough issue and pull request threads about this topic and it would be good to wrap it up in at most one or two pulls.

@dergoegge
Copy link
Copy Markdown
Member Author

I am happy to submit a pull

Yes please

@dergoegge dergoegge closed this Oct 31, 2024
@bitcoin bitcoin locked and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bench: linearizeoptimallyexample11 benchmark now running 4x slow than previously

3 participants