Qt: move paymentACK handling to paymentserver#3130
Qt: move paymentACK handling to paymentserver#3130laanwj merged 1 commit intobitcoin:masterfrom Diapolo:paymentACK_via_message
Conversation
|
Haven't looked at it in detail yet, but moving the message to PaymentServer makes sense as it only re-emits a message. |
|
I don't think we should make the paymentack message a tray message. |
|
@laanwj That's fine with me... perhaps there are better methods for handling this message, but that's out of the score of this pr. |
|
Updated:
|
There was a problem hiding this comment.
Hm I'd suggest to keep the signal, and subscribe to it locally; what if we want to do something else with the ACK later on?
- add new slot handlePaymentACK() to paymentserver, which handles paymentACK messages (currently we just display them) - make paymentACK message a modal information dialog - change some QObject::tr() to just tr() - clarify the processPaymentRequest() error, when IsDust() - small string change to prevent a tripple + usage with QString
|
Updated to reflect @laanwj's suggestion:
|
|
ACK |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/08dd1b7be172f7ea580dc9bdf20ac15ea9a2ed31 for binaries and test log. |
Qt: move paymentACK handling to paymentserver
paymentACK messages (currently we just display them)