test: Improve STRICTENC/DERSIG unit tests #34295
Open
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34295. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste LLM Linter (✨ experimental)Possible typos and grammar issues:
2026-01-30 14:34:16 |
darosior
approved these changes
Jan 29, 2026
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
ACK 63ff7c4
Could you add the context given in OP to the commit messages? It's useful to be able to have the context for a change (especially one that isn't immediate such as this one) when git blaming or searching through the git history, without having to rely on Github.
script_invalid.json no longer exists.
Fix a test that isn't implemented as intended. The idea is to test execution order by providing a signature that would cause script failure when parsed. An empty signature does not cause script failure in CHECKMULTISIG. Use OP_1 for the second signature instead of OP_0.
Copy existing STRICTENC tests and change the flag to DERSIG.
darosior
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a comment referencing a file that no longer exists in the codebase:
script_invalid.json.Fix a test that isn't implemented as intended. The idea is to test execution order by providing a signature that would cause script failure when parsed. An empty signature does not cause script failure in
CHECKMULTISIG. UseOP_1for the second signature instead ofOP_0.Copy existing
STRICTENCtests and change the flag toDERSIG.DERSIGis a consensus flag (unlikeSTRICTENC), so it'd be good to have dedicated test cases.script_testspass on my end.