bench: add WalletBalanceManySpent for high-history wallet scenario #34360
+192
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a benchmark that measures `GetBalance()` performance on wallets with extensive transaction history where most outputs have been spent. Scenario: 50,000 TXOs with 49,950 spent and 50 unspent. This pattern is common in high-activity wallets (Lightning nodes, exchange hot wallets, payment processors) and is the target scenario for optimizations that separate spent TXOs from spendable ones. Setup: - Creates 500 blocks × 100 coinbase outputs = 50,000 wallet TXOs - Matures all coinbases with COINBASE_MATURITY additional blocks - Spends 49,950 outputs in batched transactions (confirmed in blocks) - Consolidation outputs go to a burn script to avoid inflating wallet TXO count Introduces `src/bench/wallet_bench_util.h` with utilities for wallet benchmarks (TipBlock, GetTip, GenerateFakeBlock).
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34360. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. LLM Linter (✨ experimental)Possible places where named args for integral literals may be used (e.g.
2026-01-21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new benchmark that measures
GetBalance()performance on wallets with extensive transaction history where the majority of outputs have already been spent.It was created to test #27865, which separates spent TXOs from spendable ones.
This pattern mirrors real-world usage in high-activity wallets such as Lightning nodes, exchanges, hot wallets, and payment processors.
Setup:
To keep the setup time reasonable, the benchmark uses the fast “fake block” approach, similar to
wallet_create_tx.cpp.