Skip to content

util, iwyu: Add missed header#35186

Merged
fanquake merged 1 commit intobitcoin:masterfrom
hebasto:260430-feefrac-header
Apr 30, 2026
Merged

util, iwyu: Add missed header#35186
fanquake merged 1 commit intobitcoin:masterfrom
hebasto:260430-feefrac-header

Conversation

@hebasto
Copy link
Copy Markdown
Member

@hebasto hebasto commented Apr 30, 2026

This PR amends #34669 and fixes the CI.

@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Apr 30, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK brunoerg, pinheadmz

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Copy link
Copy Markdown
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d28179b

@pinheadmz
Copy link
Copy Markdown
Member

ACK d28179b

should fix failure seen here https://github.com/bitcoin/bitcoin/actions/runs/25186108957/job/73843745290


>>> Fixing #includes in '/home/admin/actions-runner/_work/_temp/src/util/feefrac.h'
IWYU edited 1 files on your behalf.

Formatting src/util/feefrac.h
+ git --no-pager diff --exit-code
diff --git a/src/util/feefrac.h b/src/util/feefrac.h
index 702f5d4..f9c9a0a 100644
--- a/src/util/feefrac.h
+++ b/src/util/feefrac.h
@@ -9,6 +9,7 @@
 #include <util/overflow.h>
 
 #include <compare>
+#include <concepts>
 #include <cstdint>
 #include <span>
 #include <utility>
+ echo '^^^ ⚠️ Failure generated from IWYU'
^^^ ⚠️ Failure generated from IWYU
+ false
Command '['docker', 'exec', '--env', 'DANGER_RUN_CI_ON_HOST=1', 'f09d47524926eddf61f6a9dfa158aa864b8c907aab458b3cb1ce9caad3d8028f', '/home/admin/actions-runner/_work/_temp/ci/test/03_test_script.sh']' returned non-zero exit status 1.

@fanquake fanquake merged commit 25100fc into bitcoin:master Apr 30, 2026
25 checks passed
@hebasto hebasto deleted the 260430-feefrac-header branch April 30, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants