doc: Fix broken links in dev notes, move sections#35296
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35296. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
janb84
left a comment
janb84
left a comment
There was a problem hiding this comment.
ACK fab42cf
I have validated that the fixed links indeed work (on both safari and chromium).
Also validated that there aren't any leftover broken links in the doc, regarding C++ core guidelines.
The reordering of the document seems logical to me, LGTM.
* Remove the explicit modernize-use-nullptr rule mention, which has not been needed for years. * Encourage devs to refer to the upstream clang-tidy rules documentation. * Move NOLINTNEXTLINE(misc-no-recursion) into a subsection under the new clang-tidy section.
Doxygen is about the C++ comment style, so move the Python section to have all C++ style sections in one flow.
Valgrind is often used as a sanitizer, so move it closer to the Sanitizer section.
Previously, they have been in the "Tips and tricks" section, which seems a bit off.
maflcko
force-pushed
the
2605-doc-fix-links
branch
from
fadc000 to
faf6afd
Compare
3 participants
The anchors in isocpp links were recently broken, so fix them to point to the correct anchor.
Also, move/regroup 3 sections while touching the file.