Skip to content

use english for all reason strings in IsStandardTx()#3589

Merged
jgarzik merged 1 commit intobitcoin:masterfrom
Diapolo:english-reason
Jan 28, 2014
Merged

use english for all reason strings in IsStandardTx()#3589
jgarzik merged 1 commit intobitcoin:masterfrom
Diapolo:english-reason

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Jan 27, 2014

No description provided.

@Michagogo
Copy link
Copy Markdown
Contributor

Heh, I remember seeing the "mucho-data" thing, from whoever put that in in some PR, but I didn't realize it has actually made it in.

EDIT: Looks like it was @jgarzik, in a793424

@sipa
Copy link
Copy Markdown
Member

sipa commented Jan 27, 2014

Wut? Why the hell was that merged?

@Michagogo
Copy link
Copy Markdown
Contributor

#2738 (diff)

@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Jan 27, 2014

Right, I remember I posted a mild protest in the pull, but didn't want to sound like the all-day-long nitter.
Edit: After the merge I even started giving serious protests (be484db) no one seemed to care...

@gmaxwell
Copy link
Copy Markdown
Contributor

data-size is perhaps confusing, since I'd expect that to be e.g. for txn >100kb. Would op-return-data-size be too verbose?

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Jan 28, 2014

Agreed. "multi-op-return" was Gavin's proposal and makes sense.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b34e88a88f8e8c0b73292853fbce73a5f86c7dcc for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jgarzik
Copy link
Copy Markdown
Contributor

jgarzik commented Jan 28, 2014

You guys have absolutely no sense of humor whatsoever. :)

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Jan 28, 2014

return "no-mucho-humor"

jgarzik pushed a commit that referenced this pull request Jan 28, 2014
use english for all reason strings in IsStandardTx()
@jgarzik jgarzik merged commit 12e1fcc into bitcoin:master Jan 28, 2014
@Diapolo Diapolo deleted the english-reason branch January 28, 2014 09:50
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants