minor style cleanups#3650
Conversation
d8b4b49 Don't store or send side-chain blocks lower than last checkpoint. (Ashley Holman)
There was a problem hiding this comment.
As you already go through style cleanups here, I was thinking about removing the excessive use of "{" "}" there around one-liner if-else-statements.
There was a problem hiding this comment.
I'd favor this, but I guess @laanwj will kill me then ;).
There was a problem hiding this comment.
I've always found that { } are a good thing as they explicitly mark the beginning and end of a scope, which is good for maintainability. I've had to debug problems caused by people adding code like this many times:
if (!something)
send = true;
return; /// Oops
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2b45345aaca9d0091972f983ac6e5c0b09d14777 for binaries and test log. |
2b45345 minor style cleanups (Philip Kaufmann)
…oin#3650) It seems like the idea here was to avoid announcing already available sigshares for a signhash to everyone if concentrated recovery is enabled. But by returning there if `IsAllMembersConnectedEnabled` equals to `false` we disable the re-announcements prior to the spork activation, where we want to still have them and re-enable if the spork is enabled where we don't want to have them.
5 participants
No description provided.