Skip to content

fix non-standard reason string in main.cpp#3666

Merged
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:scriptsig
Feb 17, 2014
Merged

fix non-standard reason string in main.cpp#3666
laanwj merged 1 commit intobitcoin:masterfrom
Diapolo:scriptsig

Conversation

@Diapolo
Copy link
Copy Markdown

@Diapolo Diapolo commented Feb 13, 2014

No description provided.

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bbfce8a4c9e7541d06dcc857dd0a82ec14d92180 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jgarzik
Copy link
Copy Markdown
Contributor

jgarzik commented Feb 13, 2014

I cannot discern from your commit message, or the patch, why this is a "fix", or is needed at all.

@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Feb 13, 2014

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Feb 13, 2014

@Diaplo Can you link to the standard that would make this nonstandard? I cannot find any of these reasons in BIP0022 in a quick glance.

@petertodd
Copy link
Copy Markdown
Contributor

ACK

Good to be clear as to where the non-standardness is given scriptPubKeys are allowed to have non-standard pushdata's. If that changes in the future we can create an additional scriptPubKey-non-canonical-push message.

@Diapolo
Copy link
Copy Markdown
Author

Diapolo commented Feb 16, 2014

See above links, I just used the wording that WAS already used for the other reason strings... I don't claim there is a BIP for this :-P.

@sipa
Copy link
Copy Markdown
Member

sipa commented Feb 16, 2014

ACK

laanwj added a commit that referenced this pull request Feb 17, 2014
bbfce8a fix non-standard reason string in main.cpp (Philip Kaufmann)
@laanwj laanwj merged commit bbfce8a into bitcoin:master Feb 17, 2014
@Diapolo Diapolo deleted the scriptsig branch February 17, 2014 13:55
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants