Skip to content

Clarify the message when unable to bind port#3798

Merged
laanwj merged 2 commits intobitcoin:masterfrom
paveljanik:patch-1
Mar 5, 2014
Merged

Clarify the message when unable to bind port#3798
laanwj merged 2 commits intobitcoin:masterfrom
paveljanik:patch-1

Conversation

@paveljanik
Copy link
Copy Markdown
Contributor

When bitcoind can't bind, bitcoin server (or Bitcoin Core Daemon) is probably already running. Add the missing word "server". Bitcoin itself is definitely running ;-)

Add _(...) so the string can be localized.

I apologize for such trivial changes, learning github interface (if I'm doing something wrong, please tell me so, thank you).

When bitcoind can't bind, bitcoin server (or Bitcoin Core Daemon) is probably already running. Add the missing word "server". Bitcoin itself is definitely running ;-)

Add _(...) so the string can be localized.

I apologize for such trivial changes, learning github interface.
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Mar 5, 2014

Can you make the commit message a bit more informative? (something like: clarify message when unable to bind port)

No need to apologize for trivial changes, making help and error messages more clear is worth it and, unlike other code changes, easy to review.

@laanwj
Copy link
Copy Markdown
Member

laanwj commented Mar 5, 2014

ACK

@BitcoinPullTester
Copy link
Copy Markdown

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2d2d8fae3d8bc4e82dc631d93c6e19f954bbee04 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

laanwj added a commit that referenced this pull request Mar 5, 2014
2d2d8fa Clarify the error message when unable to bind to port (paveljanik)
094eeff Bitcoin is running fine... (paveljanik)
@laanwj laanwj merged commit 2d2d8fa into bitcoin:master Mar 5, 2014
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Mar 5, 2014

Next time please squash commits into one, for example using git rebase -i.
(if you have multiple small changes, submitting them as separate commits makes no sense)

@paveljanik
Copy link
Copy Markdown
Contributor Author

Thanks, will try to do. I'm trying to use only github web UI to learn its possibilities...

@paveljanik paveljanik deleted the patch-1 branch March 5, 2014 10:58
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants